Stream: wg-traits

Topic: refactor types #42340


nikomatsakis (Oct 01 2019 at 14:27, on Zulip):

Hey @csmoe -- just saw your PR #64817 -- funny you should open that, as in thinking things through last night I had identified #42340 as one of the first projects we should focus on in/around wg-traits.

nikomatsakis (Oct 01 2019 at 14:28, on Zulip):

I'll take a look!

nikomatsakis (Oct 01 2019 at 14:28, on Zulip):

And yes, I'm behind on reviewing =)

nikomatsakis (Oct 01 2019 at 20:13, on Zulip):

I'm reading this now.

nikomatsakis (Oct 01 2019 at 20:13, on Zulip):

I'm also thinking about @blitzerr's branch and shedding a small tear

nikomatsakis (Oct 01 2019 at 20:13, on Zulip):

maybe after you land this PR @csmoe you might want to take a stab at doing the "RFC 2229" refactoring :)

blitzerr (Oct 01 2019 at 20:24, on Zulip):

I'm also thinking about blitzerr's branch and shedding a small tear

@nikomatsakis Its unfortunate. I will resume that after the traits and future issues are done

nikomatsakis (Oct 01 2019 at 20:27, on Zulip):

@csmoe left a review here

csmoe (Oct 08 2019 at 15:34, on Zulip):

maybe after you land this PR csmoe you might want to take a stab at doing the "RFC 2229" refactoring :slight_smile:

@nikomatsakis closure/generator were doned. for "refactoring", did you mean rebasing blitzerr's paused branch onto master or else?

nikomatsakis (Oct 08 2019 at 15:44, on Zulip):

@csmoe good question. What I meant by that comment was yes, rebasing (or, more likely, reimplementing) @blitzerr's branch

nikomatsakis (Oct 08 2019 at 15:44, on Zulip):

But I was also thinking that in terms of #42340 it'd be good to start a "design document" with what we think types should look like

nikomatsakis (Oct 08 2019 at 15:44, on Zulip):

I think the structure outlined in the issue is too simplistic

nikomatsakis (Oct 08 2019 at 15:44, on Zulip):

chalk is probably pretty close to the right "overall shape"

csmoe (Oct 08 2019 at 16:36, on Zulip):

csmoe good question. What I meant by that comment was yes, rebasing (or, more likely, reimplementing) blitzerr's branch

okay, any updates on the previous implementation approach? or I will review the doc on dropbox.

csmoe (Oct 08 2019 at 16:55, on Zulip):

ohh, wait, before restarting, I wanna hear from @blitzerr as they said: "...I will resume that after the traits and furture issues..", may I take over this matter from you?

csmoe (Oct 08 2019 at 17:02, on Zulip):

But I was also thinking that in terms of #42340 it'd be good to start a "design document" with what we think types should look like

@nikomatsakis sorry, I'm incapable to provide valuable ideas on such "design document" but eager to volunteer, but need help from your seniors to sketch out that.

Last update: Nov 18 2019 at 01:35UTC