Stream: wg-traits

Topic: refactoring chalk


nikomatsakis (Mar 30 2019 at 20:09, on Zulip):

fyi, I'm mostly afk this week, but i'm doing various bits of refactoring on chalk trying to turn it into an on-demand, query-driven system. This is requiring a bit more experimentation than anticipated. (cc @scalexm -- I don't think you had much work-in-progress here, right?)

scalexm (Mar 30 2019 at 20:10, on Zulip):

@nikomatsakis I did have a bit of work-in-progress, but I was mostly getting acquainted with salsa actually

nikomatsakis (Apr 05 2019 at 11:36, on Zulip):

ps, still, mostly afk, but in case you're curious you can see my progress in my querify branch -- I haven't gotten to the actual queries yet, but I've mostly disentangled the various interdependencies between the rust-ir, rules, etc so that there are smaller pieces that can be recombined. I'm just now getting to the deeper changes.

nikomatsakis (Apr 10 2019 at 13:40, on Zulip):

PR posted https://github.com/rust-lang/chalk/pull/211

nikomatsakis (Apr 10 2019 at 13:41, on Zulip):

I think what makes sense is that I should try to sketch out the end-state I envision as well as the current state

nikomatsakis (Apr 10 2019 at 13:41, on Zulip):

I've been contemplating the right sort of diagrams for this :)

nikomatsakis (Apr 10 2019 at 13:41, on Zulip):

It's a rather long PR

nikomatsakis (Apr 10 2019 at 13:41, on Zulip):

and maybe then we should try to dig into that in either a recorded Zoom call or a sync Zulip meeting

nikomatsakis (Apr 10 2019 at 13:42, on Zulip):

cc @Florian Diebold and @matklad, this is relevant to rust-analyzer

nikomatsakis (Apr 10 2019 at 13:42, on Zulip):

It's a rather long PR

what I meant by this is that I would expect it to be hard to follow without understanding what I was going for (and, in some cases, I was just opportunistically doing refactorings without knowing where I was going :)

nikomatsakis (Apr 10 2019 at 13:43, on Zulip):

cc @WG-traits :point_up:

scalexm (Apr 10 2019 at 13:52, on Zulip):

Big PR indeed

scalexm (Apr 10 2019 at 13:53, on Zulip):

I quickly skimmed through it, but I’ll have a deeper look within the next few days

nikomatsakis (Apr 12 2019 at 12:35, on Zulip):

So @WG-traits -- what do you y'all think about using the meeting on monday (perhaps extended to 1hour) to discuss this in more depth? (Over Zulip, I imagine)

I can try to prepare a brief write-up with the structure I created and some of the things I think we still have yet to do. (I spent some time today thinking about how best to diagram it, I'd like to have some documentation of this for future humans who might like to read the source.)

matklad (Apr 12 2019 at 12:38, on Zulip):

As a potential future human, I would appreciate the diagram :) I feel like chalk integration would be the point where I stop understanding fully how rust-analyzer works )

Last update: Nov 12 2019 at 16:20UTC