Stream: wg-traits

Topic: (no topic)


Alexander Regueiro (Mar 11 2019 at 20:43, on Zulip):

(deleted)

Clinton Mead (Dec 04 2019 at 11:07, on Zulip):

I was thinking about implementing generalised HRTBs (some discussion here: https://internals.rust-lang.org/t/generalising-hrtbs/11417) and I was just looking for some pointers about where to start. I've had a look around the "Guide to Rustc Development" and in particular I'm not sure whether to go with the "old style" or "new style" (presumably "chalk") trait solving at this point?

Aaron Hill (Jan 23 2020 at 23:42, on Zulip):

I'd like to get involved in this WG - what would be the best place for me to start?

Jack Huey (Jan 24 2020 at 01:37, on Zulip):

@Aaron Hill anything in particular that you're interested in?

Jack Huey (Jan 24 2020 at 01:37, on Zulip):

I think like 70-90% of what we talk about is Chalk-related (at least the past couple months)

Jack Huey (Jan 24 2020 at 01:38, on Zulip):

(minutes that aren't entirely up to date: https://github.com/rust-lang/wg-traits/tree/master/minutes)

Aaron Hill (Jan 24 2020 at 01:38, on Zulip):

anything Chalk-related sounds good

Jack Huey (Jan 24 2020 at 01:38, on Zulip):

We've been having weekly meetings Monday at 2PM EST. I'm not going to be able to make those anymore, so it might change (pending feedback from @nikomatsakis and others)

Jack Huey (Jan 24 2020 at 01:39, on Zulip):

For Chalk-related things

Jack Huey (Jan 24 2020 at 01:39, on Zulip):

I'm actually putting together some goals (which I really need to finish)

Jack Huey (Jan 24 2020 at 01:39, on Zulip):

https://hackmd.io/VeMmXIYBRu2KdYbJDIpcFA

Jack Huey (Jan 24 2020 at 01:40, on Zulip):

But we're also trying to work towards getting current Chalk integrated into rustc

Jack Huey (Jan 24 2020 at 01:41, on Zulip):

Project here: https://github.com/rust-lang/wg-traits/projects/2

Jack Huey (Jan 24 2020 at 01:44, on Zulip):

I'm trying to think of some "relatively easy" things to start off with

Jack Huey (Jan 24 2020 at 01:47, on Zulip):

One thing that we've talked about recently but nobody really worked on yet is replacing Chalk's debug/log system with tracing. @David Barsky said he was going to make a PR for that a couple weeks ago, but I think they wanted to improve the tracing crate a bit first

Jack Huey (Jan 24 2020 at 01:47, on Zulip):

But, it would be a really good place to start, since it's fairly simple, but also can help to get your eyes on a lot of the chalk code

David Barsky (Jan 24 2020 at 01:47, on Zulip):

@Jack Huey yes, sorry about that—I've been a bit overwhelmed these last few weeks!

Jack Huey (Jan 24 2020 at 01:48, on Zulip):

@David Barsky yeah, no problem :) I've been pretty busy myself since coming back from christmas vacation

David Barsky (Jan 24 2020 at 01:49, on Zulip):

you can probably start on it now, to be honest. I've gotten most of the docs into a state I'm happy with, but I never got the hierarchal formatter over the line. it might take only an hour or so.

Jack Huey (Jan 24 2020 at 01:51, on Zulip):

@Aaron Hill so yeah, take a look through some of those links and let me know if you see anything interesting or have questions :)

David Barsky (Jan 24 2020 at 01:51, on Zulip):

e.g., this is _way_ better than what it used to be https://github.com/tokio-rs/tracing#usage

nikomatsakis (Feb 07 2020 at 22:02, on Zulip):

ps @Aaron Hill (and @David Barsky), the #wg-traits > goals and next steps discussion seems pretty pertinent :)

David Barsky (Feb 07 2020 at 22:19, on Zulip):

Thank you! Reading through it is pretty cool :)

Jack Huey (Feb 14 2020 at 20:14, on Zulip):

Well today is active here

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

has anyone fixed this warning already or is it okay if I fix this in one of my PRs?

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

```warning: unnecessary parentheses around block return value
--> /home/jlusby/git/rust/chalk/target/debug/build/chalk-parse-101ab32be25c139a/out/parser.rs:44066:5
|
44066 | (__0)
| ^^^^^ help: remove these parentheses

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

fking zulip

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

Jane Lusby (Mar 17 2020 at 22:32, on Zulip):

wow

nikomatsakis (Mar 17 2020 at 22:33, on Zulip):

uh :)

Jane Lusby (Mar 17 2020 at 22:35, on Zulip):

anyways, it looks like this code is auto generated, im assuming I can just find the code that generates it and add an #![allow(unused_parens)] to the top of the generated file

Jane Lusby (Mar 17 2020 at 22:38, on Zulip):

hmm

lqd (Mar 17 2020 at 23:02, on Zulip):

(if you haven't found it yet, it's likely you can add that here next to the rustfmt skip, but inside the macro would work as well iirc)

Jack Huey (Mar 25 2020 at 17:09, on Zulip):

@nikomatsakis if you get some time, can we move this forward: https://github.com/rust-lang/chalk/pull/355

Last update: Jun 07 2020 at 09:50UTC