I was thinking about implementing generalised HRTBs (some discussion here: https://internals.rust-lang.org/t/generalising-hrtbs/11417) and I was just looking for some pointers about where to start. I've had a look around the "Guide to Rustc Development" and in particular I'm not sure whether to go with the "old style" or "new style" (presumably "chalk") trait solving at this point?
I'd like to get involved in this WG - what would be the best place for me to start?
@Aaron Hill anything in particular that you're interested in?
I think like 70-90% of what we talk about is Chalk-related (at least the past couple months)
(minutes that aren't entirely up to date: https://github.com/rust-lang/wg-traits/tree/master/minutes)
anything Chalk-related sounds good
We've been having weekly meetings Monday at 2PM EST. I'm not going to be able to make those anymore, so it might change (pending feedback from @nikomatsakis and others)
For Chalk-related things
I'm actually putting together some goals (which I really need to finish)
But we're also trying to work towards getting current Chalk integrated into rustc
Project here: https://github.com/rust-lang/wg-traits/projects/2
I'm trying to think of some "relatively easy" things to start off with
One thing that we've talked about recently but nobody really worked on yet is replacing Chalk's debug/log system with
tracing. @David Barsky said he was going to make a PR for that a couple weeks ago, but I think they wanted to improve the tracing crate a bit first
But, it would be a really good place to start, since it's fairly simple, but also can help to get your eyes on a lot of the chalk code
@Jack Huey yes, sorry about that—I've been a bit overwhelmed these last few weeks!
@David Barsky yeah, no problem :) I've been pretty busy myself since coming back from christmas vacation
you can probably start on it now, to be honest. I've gotten most of the docs into a state I'm happy with, but I never got the hierarchal formatter over the line. it might take only an hour or so.
@Aaron Hill so yeah, take a look through some of those links and let me know if you see anything interesting or have questions :)
e.g., this is _way_ better than what it used to be https://github.com/tokio-rs/tracing#usage
ps @Aaron Hill (and @David Barsky), the #wg-traits > goals and next steps discussion seems pretty pertinent :)
Thank you! Reading through it is pretty cool :)
Well today is active here
has anyone fixed this warning already or is it okay if I fix this in one of my PRs?
```warning: unnecessary parentheses around block return value
44066 | (__0)
| ^^^^^ help: remove these parentheses
anyways, it looks like this code is auto generated, im assuming I can just find the code that generates it and add an #![allow(unused_parens)] to the top of the generated file
(if you haven't found it yet, it's likely you can add that here next to the rustfmt skip, but inside the macro would work as well iirc)
@nikomatsakis if you get some time, can we move this forward: https://github.com/rust-lang/chalk/pull/355