@Alexander Regueiro ok so I was reading into Fix for "ambiguous associated type" issue with ATBs #61919 -- I may take a stab at writing some comments again and push them to your branch. It's hard for me to summarize what's going on in any other way I think :)
Feel free to reinstate the hunk I reverted and comment it out actually -- but just fix it by swapping the pair
(def_id, None) or whatever with
(None, def_id) (so that the
impl_def_id gets set rather than
but yeah, comments are good regardless!
ok @Alexander Regueiro see this review -- something was bothering me so I investigated more deeply.
Makes sense. That same thing was bothering me too, but you got to the bottom of it, which is great. Will have a closer look soon!