Stream: wg-traits

Topic: pr #61919


nikomatsakis (Jul 11 2019 at 16:35, on Zulip):

@Alexander Regueiro ok so I was reading into Fix for "ambiguous associated type" issue with ATBs #61919 -- I may take a stab at writing some comments again and push them to your branch. It's hard for me to summarize what's going on in any other way I think :)

Alexander Regueiro (Jul 11 2019 at 17:51, on Zulip):

Sounds good

Alexander Regueiro (Jul 11 2019 at 18:11, on Zulip):

Feel free to reinstate the hunk I reverted and comment it out actually -- but just fix it by swapping the pair (def_id, None) or whatever with (None, def_id) (so that the impl_def_id gets set rather than trait_def_id)

Alexander Regueiro (Jul 11 2019 at 18:11, on Zulip):

but yeah, comments are good regardless!

nikomatsakis (Jul 12 2019 at 10:32, on Zulip):

ok @Alexander Regueiro see this review -- something was bothering me so I investigated more deeply.

Alexander Regueiro (Jul 13 2019 at 00:46, on Zulip):

Makes sense. That same thing was bothering me too, but you got to the bottom of it, which is great. Will have a closer look soon!

Last update: Nov 12 2019 at 16:15UTC