Stream: wg-traits

Topic: Solver caching


matklad (Jan 06 2020 at 14:08, on Zulip):

At the moment, we use an untracted read when creating a salsa solver. That means that after every change (even a change in a comment), we re-create the solver. In the past week, we twice

matklad (Jan 06 2020 at 14:09, on Zulip):

saw cases where caching the solver more aggressively would be benefitial. That is, we implemented an (unsound) caching which invalidated solver only if the set of top-level items changed, and it led to noticible perf improvements.

matklad (Jan 06 2020 at 14:10, on Zulip):

I wonder what is our long-term plan here?

matklad (Jan 06 2020 at 14:11, on Zulip):

See https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/Completion.20latency.3F/near/184906243 for the recent example where adding cache speeds up completion a bunch

Last update: Jan 21 2020 at 08:55UTC