Stream: wg-traits

Topic: floundering


nikomatsakis (Jun 04 2019 at 00:58, on Zulip):

I opened a PR with the floundering work: https://github.com/rust-lang/chalk/pull/229

r? @scalexm

scalexm (Jun 09 2019 at 21:17, on Zulip):

@nikomatsakis reviewed

matklad (Jul 09 2019 at 07:44, on Zulip):

@Florian Diebold did you check if floundering helps with rust-analyzer perf issues?

Florian Diebold (Jul 09 2019 at 09:04, on Zulip):

No I didn't yet, but I should... As I understand it we'll have to somehow mark traits as non-enumerable though

Florian Diebold (Jul 14 2019 at 17:17, on Zulip):

Well, it seems like it might. Here are numbers for analyzing the Chalk repo:
Everything enumerable, using fuel: 20.685380613s
Everything enumerable, without fuel: 20.752197389s
Everything enumerable, removing our hardcoded blacklist of 'bad' traits (Send, Sync, Sized, the Fn traits): seems to hang indefinitely
Marking those traits as non-enumerable instead: 21.311616989s

Florian Diebold (Jul 14 2019 at 17:37, on Zulip):

(Actually only Sized needs to be marked as non-enumerable, since auto traits are non-enumerable anyway and it doesn't seem to be necessary for the Fn traits)

nikomatsakis (Aug 29 2019 at 22:06, on Zulip):

btw @Florian Diebold I'm planning on spending tomorrow/Monday catching up on the work you've been doing in rust-analyzer, along with some other trait stuff, maybe we can chat some on Monday?

Florian Diebold (Aug 30 2019 at 06:48, on Zulip):

Sure, on Monday I'll be busy between 19:00-21:30 CET, but apart from that any time

Last update: Nov 12 2019 at 16:45UTC