Stream: wg-traits

Topic: issue triage and labels


Jack Huey (Feb 07 2020 at 02:31, on Zulip):

Okay, so I remade the issue labels and labeled the issues as needed

Jack Huey (Feb 07 2020 at 02:34, on Zulip):

There's now a "need triage" label specifically to mark for discussion (somewhat parallel to rustc's nominated)

Jack Huey (Feb 07 2020 at 02:34, on Zulip):

In particular, I've marked 7 of them under this

Jack Huey (Feb 07 2020 at 02:35, on Zulip):

I'll go through them and explain why. This is mostly for @nikomatsakis to respond as needed, but also if anyone else has comments

Jack Huey (Feb 07 2020 at 02:37, on Zulip):

inference, lazy normalization, and occurs check. This is 3 years old at this point. Nothing actionable and relevant FIXMEs are no longer there. Should we close or identify something actionable

Jack Huey (Feb 07 2020 at 02:39, on Zulip):

Elaborating where clauses on traits, structs. Similar, 3 years old. Really not sure what to do with this.

Jack Huey (Feb 07 2020 at 02:41, on Zulip):

README doesn't make it clear exactly what chalk is. I think this one is probably closable. I definitely want to go through the README and clean up a bit, but there isn't really anything actionable here. It also is supplemented by the book.

Jack Huey (Feb 07 2020 at 02:42, on Zulip):

support "specialized" impls. @Aaron Hill also asked about this status. Anything left to do here that isn't covered more generally by https://github.com/rust-lang/chalk/issues/9?

Jack Huey (Feb 07 2020 at 02:44, on Zulip):

refine RustIrDatabase interface. Is there more design work to do here? Seems like the branch you link is merged?

Jack Huey (Feb 07 2020 at 02:47, on Zulip):

make chalk inner loop "fuel friendly". I think this one is "done" with the changes in https://github.com/rust-lang/chalk/pull/321. I think that I should open up a follow up issue though with some improvements I want to make to solve_limited. I'm curious what you mean when you mean floundering and cycles do an unbounded amount of work. (cycle somewhat I know, but not entirely)

Jack Huey (Feb 07 2020 at 02:50, on Zulip):

extract rustc-guide content to make a chalk book. So, we obviously have a book. It's incomplete, so maybe we use this as a tracking issue. The only thing I think still relevant with this is mentioning CHALK_DEBUG and reading list, though I think we have places for those

Jack Huey (Feb 07 2020 at 02:50, on Zulip):

And that's everything

Jack Huey (Feb 12 2020 at 15:22, on Zulip):

@nikomatsakis if you could dedicate a bit of time to at least go through each of these and decide if they can/should be closed, or clarify what needs to be done going forward that would be nice :)

nikomatsakis (Feb 12 2020 at 15:22, on Zulip):

I will try to do that today and if not today then Friday

nikomatsakis (Feb 12 2020 at 15:22, on Zulip):

but I think I can do that today :)

nikomatsakis (Feb 12 2020 at 15:22, on Zulip):

/me adds to daily to do list

Jack Huey (Feb 12 2020 at 16:10, on Zulip):

It's not super urgent. But I figured a bit of a ping would be helpful

nikomatsakis (Feb 14 2020 at 19:12, on Zulip):

OK let me get to this finaklly

nikomatsakis (Feb 14 2020 at 19:13, on Zulip):

Jack Huey said:

inference, lazy normalization, and occurs check. This is 3 years old at this point. Nothing actionable and relevant FIXMEs are no longer there. Should we close or identify something actionable

I think we should just close this. There may be a relevant problem that arises as we push further through, but let's wait till we have some concrete examples of the problem.

nikomatsakis (Feb 14 2020 at 19:55, on Zulip):

Jack Huey said:

Elaborating where clauses on traits, structs. Similar, 3 years old. Really not sure what to do with this.

to some extent we "implemented" this -- the lowering rules include elaboration and implied bounds. I do think there is some problem here in that the rules chalk implements are different (arguably better, but still) than what rustc does. They are really implementing the rules from rfc#2089

nikomatsakis (Feb 14 2020 at 19:55, on Zulip):

Still, I think we should close this particular issue

nikomatsakis (Feb 14 2020 at 19:56, on Zulip):

I sort of think though that the "concept" of aligning this stuff should move into the "skill-tree"

nikomatsakis (Feb 14 2020 at 19:56, on Zulip):

I think a lot of these "higher-level" things ought to move there instead, issues should be for more immediately actionable things

Last update: Feb 25 2020 at 04:20UTC