Stream: wg-traits

Topic: test organization


detrumi (May 06 2019 at 20:22, on Zulip):

I've created an issue to track the test refactorings: https://github.com/rust-lang/chalk/issues/224

detrumi (May 07 2019 at 07:55, on Zulip):

@nikomatsakis Types like db::ChalkDatabase and query::LoweringDatabase are used by both chalki and the tests, would it make sense to move these out to a new crate ("chalk-model"?), or would that be too much splitting?

nikomatsakis (May 07 2019 at 13:39, on Zulip):

Mmm, I guess I could go either way. I think you could have a chalk-integration crate that has a bunch of #[test] tests, and a chalki uses that .. but I also think it'd be ok to pull the tests out into their own crates

detrumi (May 07 2019 at 20:26, on Zulip):

There were some problems with circular dependencies, so I ended up creating a chalk-integration crate, and wf.rs fit there better as well

detrumi (May 17 2019 at 08:12, on Zulip):

Hmm, now chalk-tests depends on chalk-integration, which depends on chalk-solve (which is the root crate)... So now the tests can't be moved to a /tests directory, since it'd be a dependency cycle then

nikomatsakis (May 17 2019 at 17:48, on Zulip):

I think you can use a dev-dependency for this

nikomatsakis (May 17 2019 at 17:48, on Zulip):

but maybe I am wrong?

Last update: Nov 12 2019 at 15:30UTC