Stream: t-compiler

Topic: approve #62055


simulacrum (Jun 25 2019 at 20:34, on Zulip):

https://github.com/rust-lang/rust/pull/62055 needs to be approved for backport quite quickly -- @nikomatsakis @pnkfelix any chance we could do that without full compiler team sign-off?

simulacrum (Jun 25 2019 at 20:34, on Zulip):

I'd like to get the beta backport PR r+-ed tomorrow morning

centril (Jun 25 2019 at 20:42, on Zulip):

cc @T-compiler more broadly

nagisa (Jun 25 2019 at 20:44, on Zulip):

We have a meeting on thursday, so will have to approve outside our process.

centril (Jun 25 2019 at 20:44, on Zulip):

@nagisa Ideally async, in this thread? -- since you're here, maybe you can organize the yay/nay?

pnkfelix (Jun 25 2019 at 21:31, on Zulip):

I suspect rfcbot would be the way to go. But it also may not be worth the hassle; there are other beta nom’ed PR’s that I suspect are higher priority

pnkfelix (Jun 25 2019 at 21:31, on Zulip):

(I’m not really here, just weighing in before I go to bed....)

simulacrum (Jun 25 2019 at 21:47, on Zulip):

Based on that it loosely sounds like maybe we're not likely to get acceptances then -- I might delay till tomorrow night with beta backport PR

pnkfelix (Jun 26 2019 at 08:59, on Zulip):

so, now that I'm back online: The particular PR that I was thinking was higher priority is PR #67154 (create a "provisional cache" to restore performance in the case of cycles)

pnkfelix (Jun 26 2019 at 08:59, on Zulip):

ah I now see that @simulacrum already commented on it

pnkfelix (Jun 26 2019 at 09:17, on Zulip):

and then I retracted the nomination of PR #62055.

Last update: Nov 22 2019 at 05:15UTC