Stream: t-compiler

Topic: Creating new GitHub tags


ecstatic-morse (Apr 27 2020 at 20:08, on Zulip):

I'd like to add an "I-slow-fixed-by-MIR-inlining" tag in the spirit of "NLL-fixed-by-NLL". Is there a procedure for this? See https://github.com/rust-lang/rust/issues/68667#issuecomment-620203064

LeSeulArtichaut (Apr 27 2020 at 20:18, on Zulip):

I don't think there is a procedure: the Prioritization WG recently added few labels and I don't think there was any procedure. Maybe ping an admin on the repo? @nikomatsakis

pnkfelix (Apr 27 2020 at 20:22, on Zulip):

one thing is that the NLL-fixed-by-NLL tag was prefixed by NLL ... i think that important, in terms of making auto-complete work well when it comes to tags like this that seem like they require a domain expert to do the testing (right?)

pnkfelix (Apr 27 2020 at 20:23, on Zulip):

so I would think it best to use something like MIR-opt-slow-fixed-by-MIR-inlining ... though maybe that particular choice of prefix is not ideal...

ecstatic-morse (Apr 27 2020 at 20:28, on Zulip):

I'll ask in the MIR opt channel. We don't really have structured issue triage AFAIK.

Jonas Schievink (Apr 27 2020 at 20:31, on Zulip):

We were talking about having more targeted labels for MIR optimizations recently, and ended up creating A-mir-opt

Jonas Schievink (Apr 27 2020 at 20:32, on Zulip):

I could imagine having dedicated labels for some of the major optimizations passes too

ecstatic-morse (Apr 27 2020 at 20:35, on Zulip):

Yeah, even just A-mir-opt-inlining would work for this purpose, since you can search for it in conjunction with I-slow

ecstatic-morse (Apr 27 2020 at 20:48, on Zulip):

It is done.

Last update: May 29 2020 at 15:45UTC