Stream: t-compiler

Topic: llvm backport stable


simulacrum (Feb 25 2020 at 23:49, on Zulip):

@pnkfelix @nikomatsakis for the release this thursday, we ended up backporting a LLVM change as well to fully fix https://github.com/rust-lang/rust/issues/69225 - someone came up with a reproduction that the revert bugfix didn't work anymore. We never approved that in compiler meetings though, but I think we should approve this change. I'm not sure what process to follow here, but we do have artifacts both with and without the fix, and can release either technically

simulacrum (Feb 26 2020 at 00:36, on Zulip):

(nikic approved said LLVM change, and it's quite minimal -- https://github.com/rust-lang/llvm-project/compare/2cb41005ed5c4747b10d2bf01d8779d3bb4ae32d...7d5e7c023053660ffe494d72ce471e48ecc7f49b#diff-5a6e7b948274577e7852f0d53de949d0)

eddyb (Feb 26 2020 at 00:37, on Zulip):

looks like a no-brainer TBH

simulacrum (Feb 26 2020 at 00:44, on Zulip):

yes, the default plan is to proceed with the LLVM backport commits

pnkfelix (Feb 26 2020 at 02:31, on Zulip):

I'm fine with the LLVM backport commits, based on the discussion thread on #69225

Last update: May 29 2020 at 18:00UTC