Stream: t-compiler

Topic: #65134 improper ctypes extern C


davidtwco (Oct 27 2019 at 10:15, on Zulip):

@eddyb do you want me to address your comments about the functions that need #[allow(improper_ctypes)] in this PR or should we open an issue for these to be resolved as a follow-up?

davidtwco (Oct 27 2019 at 10:51, on Zulip):

@eddyb (another ping, my previous ping was in an edit due to typo, so you wouldn't have been notified)

eddyb (Oct 28 2019 at 09:50, on Zulip):

I think I'll try the proc-macro changes myself, if I don't forget

eddyb (Oct 28 2019 at 18:15, on Zulip):

@davidtwco I can clean up a bit of it now that #53451 is gone :D

davidtwco (Oct 28 2019 at 18:22, on Zulip):

Awesome!

davidtwco (Oct 28 2019 at 18:22, on Zulip):

Is there anything else you want changed in #65134?

eddyb (Oct 28 2019 at 18:46, on Zulip):

I opened https://github.com/rust-lang/rust/pull/65900

eddyb (Oct 28 2019 at 18:47, on Zulip):

@davidtwco idk I don't think I want to land the allows in proc_macro, but it also depends how quickly my PR gets reviewed

eddyb (Oct 28 2019 at 18:48, on Zulip):

I don't have a strong preference, I guess. I left a couple more comments on your PR and that's it I think

davidtwco (Oct 28 2019 at 19:19, on Zulip):

@eddyb I've addressed your comments.

davidtwco (Oct 28 2019 at 19:20, on Zulip):

I don't feel strongly about the allows in proc_macro.

Last update: Nov 22 2019 at 05:25UTC