Stream: t-compiler

Topic: weekly meeting 2019-08-08 #54818


nagisa (Aug 08 2019 at 14:08, on Zulip):

Oh, today is a meeting day.

nagisa (Aug 08 2019 at 14:09, on Zulip):

cc @T-compiler/meeting

nagisa (Aug 08 2019 at 14:09, on Zulip):

We have 2 beta-nominated issues we need to vote on

nagisa (Aug 08 2019 at 14:10, on Zulip):

We also have a few nominated issues to talk about.

nagisa (Aug 08 2019 at 14:10, on Zulip):

I think we do that.

nagisa (Aug 08 2019 at 14:10, on Zulip):

For the first nominated issue:

nagisa (Aug 08 2019 at 14:10, on Zulip):

Avoid ICE when referencing desugared local binding in borrow error #63051

centril (Aug 08 2019 at 14:11, on Zulip):

Actual code change seems tiny + safe.

nagisa (Aug 08 2019 at 14:12, on Zulip):

Yeah, and something that is very nice to have backported too, although probably not critical

mw (Aug 08 2019 at 14:12, on Zulip):

any complaints since this has been merged?

centril (Aug 08 2019 at 14:12, on Zulip):

no complaints to my knowledge at least

nagisa (Aug 08 2019 at 14:13, on Zulip):

Preemptively marking as accepted

nagisa (Aug 08 2019 at 14:13, on Zulip):

Don't access a static just for its size and alignment #62982 is the next one

centril (Aug 08 2019 at 14:14, on Zulip):

(I'm a bit thunderstruck that there was no test for this before this PR)

nagisa (Aug 08 2019 at 14:14, on Zulip):

Not as simple of a PR, but fixes a stable-to-beta regression

centril (Aug 08 2019 at 14:15, on Zulip):

Does @oli want to weigh in?

nagisa (Aug 08 2019 at 14:16, on Zulip):

I’m not opposed to backporting this just because this is a regression fix

nagisa (Aug 08 2019 at 14:16, on Zulip):

I’m in favour just because of that, actually

mw (Aug 08 2019 at 14:16, on Zulip):

Seems fine to backport but I don't know the code really

centril (Aug 08 2019 at 14:16, on Zulip):

Fix has been in for 11 days -- not a very long time

nagisa (Aug 08 2019 at 14:16, on Zulip):

don’t want to have a broken beta become stable

nagisa (Aug 08 2019 at 14:17, on Zulip):

Trains move next week.

nagisa (Aug 08 2019 at 14:17, on Zulip):

So there is no time for this to bake further.

mw (Aug 08 2019 at 14:18, on Zulip):

let's do it then

mw (Aug 08 2019 at 14:18, on Zulip):

11 days is not nothing

mw (Aug 08 2019 at 14:18, on Zulip):

and there's still some time

centril (Aug 08 2019 at 14:18, on Zulip):

Yeah I agree; I'm in favor of backport but concurrently unhappy about things ;)

nagisa (Aug 08 2019 at 14:19, on Zulip):

Onto I-nominated stuff Recompiling causes panic #63349

nagisa (Aug 08 2019 at 14:20, on Zulip):

This looks like codegen unit collection thing probably

nagisa (Aug 08 2019 at 14:20, on Zulip):

but the only real conclusion I can draw is that this needs investigation.

centril (Aug 08 2019 at 14:20, on Zulip):

btw, cc @Pietro Albini ; you now have 2 new beta backports to land ^^

Pietro Albini (Aug 08 2019 at 14:20, on Zulip):

sure

Pietro Albini (Aug 08 2019 at 14:20, on Zulip):

I'll do it sometime in the next few days

mw (Aug 08 2019 at 14:21, on Zulip):

I can try to reproduce the problem

nagisa (Aug 08 2019 at 14:21, on Zulip):

P-high?

mw (Aug 08 2019 at 14:22, on Zulip):

yeah, let's call it p-high for now

nagisa (Aug 08 2019 at 14:22, on Zulip):

Next one is ICE when constructing monomorphic vtable in a static in dependent crate. #63226

centril (Aug 08 2019 at 14:22, on Zulip):

btw... could we change the ICE message to ask folks to minimize the problem before filing an issue (if they can)?

nagisa (Aug 08 2019 at 14:23, on Zulip):

well an issue on ICE is desirable regardless of whether they have a minimal reproducer or not.

centril (Aug 08 2019 at 14:24, on Zulip):

Sure it is; I'm just saying that a minimization is even better

centril (Aug 08 2019 at 14:24, on Zulip):

and it might not occur to people to minimize otherwise

nagisa (Aug 08 2019 at 14:24, on Zulip):

I think for #63226 I can only suggest @oli to sync with @mw

nagisa (Aug 08 2019 at 14:24, on Zulip):

and discuss options and whatnot

mw (Aug 08 2019 at 14:25, on Zulip):

yes, I might be able to help there

centril (Aug 08 2019 at 14:25, on Zulip):

Does this have t-lang implications?

mw (Aug 08 2019 at 14:26, on Zulip):

I don't know

nagisa (Aug 08 2019 at 14:27, on Zulip):

Assigned both of you and marked P-high

nagisa (Aug 08 2019 at 14:27, on Zulip):

Compiler panic on a macro invocation combined with invalid pub declaration #63223 already has @Vadim Petrochenkov assigned.

nagisa (Aug 08 2019 at 14:28, on Zulip):

Doesn’t appear like there is anything to discuss here.

nagisa (Aug 08 2019 at 14:29, on Zulip):

ICE in macro: doc meta with expr on an item, string concat, stringify!(...) #55414 appears to be non-regression ICE

nagisa (Aug 08 2019 at 14:30, on Zulip):

As usual for ICEs P-high.

centril (Aug 08 2019 at 14:30, on Zulip):

Seems like @Vadim Petrochenkov's wheelhouse

nagisa (Aug 08 2019 at 14:30, on Zulip):

Needs investigation

centril (Aug 08 2019 at 14:31, on Zulip):

or maybe one of the compiler contributors?

nagisa (Aug 08 2019 at 14:32, on Zulip):

Pinged @Vadim Petrochenkov, leaving unassigned for now.

nagisa (Aug 08 2019 at 14:33, on Zulip):

ICE when using anonymization in impl Trait with HRTB #54895

nagisa (Aug 08 2019 at 14:33, on Zulip):

The remaining 3 issues in general appear to share the same theme

nagisa (Aug 08 2019 at 14:33, on Zulip):

need investigation, a long-standing ICE

nagisa (Aug 08 2019 at 14:34, on Zulip):

(The other two being Compiler crash on associated type violating its bounds in a blanket impl #54108 and Trait bounds are not checked on type aliases until they are used #51626)

nagisa (Aug 08 2019 at 14:35, on Zulip):

Actually Trait bounds are not checked on type aliases until they are used #51626 is different

nagisa (Aug 08 2019 at 14:35, on Zulip):

Trait bounds are not checked on type aliases until they are used #51626 looks like T-lang to me actually

nagisa (Aug 08 2019 at 14:36, on Zulip):

not sure if we want to enforce anything on aliases.

centril (Aug 08 2019 at 14:36, on Zulip):

Long standing well known bug; type aliases do not WF-check the RHS

centril (Aug 08 2019 at 14:36, on Zulip):

we tried to fix it in the 2018 edition

centril (Aug 08 2019 at 14:36, on Zulip):

This wants lazy normalization afaik

nagisa (Aug 08 2019 at 14:37, on Zulip):

I’ll leave this nominated then, because @nikomatsakis is way better equipped to make the call on this

nagisa (Aug 08 2019 at 14:37, on Zulip):

For the other two, P-high, leaving unassigned.

nagisa (Aug 08 2019 at 14:38, on Zulip):

That’s all for I-nominated issues.

nagisa (Aug 08 2019 at 14:38, on Zulip):

There are no stable-to-beta regressions to look at

nagisa (Aug 08 2019 at 14:38, on Zulip):

Yay!

nagisa (Aug 08 2019 at 14:38, on Zulip):

There are a number of stable-to-nightly ones.

nagisa (Aug 08 2019 at 14:39, on Zulip):

Link errors on MSVC Nightly since around 2019-07-13 #63361 appears to be the only new one

nagisa (Aug 08 2019 at 14:40, on Zulip):

Alex seems to have commented on what the next step should be

nagisa (Aug 08 2019 at 14:40, on Zulip):

I generally agree with them

nagisa (Aug 08 2019 at 14:41, on Zulip):

this is not the first time target-cpu=native is not being very well behaved.

centril (Aug 08 2019 at 14:41, on Zulip):

Assign to yourself + alex?

nagisa (Aug 08 2019 at 14:43, on Zulip):

Sure, although I do not anticipate myself looking at it.

nagisa (Aug 08 2019 at 14:43, on Zulip):

There are two PRs that are waiting on us

nagisa (Aug 08 2019 at 14:43, on Zulip):

Make SyncDroplessArena allocations thread-local in the fast path #61873

nagisa (Aug 08 2019 at 14:44, on Zulip):

Seems like this is just waiting for aturon or somebody else to review it.

nagisa (Aug 08 2019 at 14:45, on Zulip):

Reverted to waiting-on-review.

centril (Aug 08 2019 at 14:45, on Zulip):

(It would be really good if those large unsafe blocks had comments.)

mw (Aug 08 2019 at 14:45, on Zulip):

It would be good to know why this is needed

nagisa (Aug 08 2019 at 14:45, on Zulip):

feel free to type your reviews on the PR itself.

nagisa (Aug 08 2019 at 14:46, on Zulip):

Turn HIR indexing into a query #59064 appears to need more than 10 minutes of a random meeting with low participation.

nagisa (Aug 08 2019 at 14:46, on Zulip):

so leaving it alone.

nagisa (Aug 08 2019 at 14:47, on Zulip):

With that all waiting-on-team are covered as well.

nagisa (Aug 08 2019 at 14:47, on Zulip):

I think it is a good spot to wrap this meeting up, having covered all the most important bases.

nagisa (Aug 08 2019 at 14:47, on Zulip):

(I hear that there should be checkin calendar somewhere, but I still have no idea where)

nagisa (Aug 08 2019 at 14:47, on Zulip):

Thanks everyone for attending!

mw (Aug 08 2019 at 14:48, on Zulip):

thanks a lot for driving, @nagisa!

Last update: Nov 22 2019 at 04:30UTC