Stream: t-compiler

Topic: crater free


Pietro Albini (Oct 25 2019 at 15:03, on Zulip):

hey y'all!

Pietro Albini (Oct 25 2019 at 15:03, on Zulip):

the crater queue is empty atm ( :heart: to microsoft for the additional builder)

Pietro Albini (Oct 25 2019 at 15:03, on Zulip):

if you want to experiment with new runs this is the best time for that!

centril (Oct 25 2019 at 15:04, on Zulip):

o.O

eddyb (Oct 25 2019 at 15:04, on Zulip):

I feel like I shouldn't have seen those messages :P

Pietro Albini (Oct 25 2019 at 15:05, on Zulip):

just don't queue 20 runs pls

Pietro Albini (Oct 25 2019 at 15:05, on Zulip):

:stuck_out_tongue:

centril (Oct 25 2019 at 15:05, on Zulip):

no promises, mkay?

eddyb (Oct 25 2019 at 15:05, on Zulip):

the good news is that I forgot what I wanted crater for, other than perhaps an upcoming PR that has some chance of breaking something obscure

eddyb (Oct 25 2019 at 15:06, on Zulip):

ohhhh riiight debuginfo. does crater compile in debug mode, with the full implication of -Cdebuginfo=2?

Pietro Albini (Oct 25 2019 at 15:06, on Zulip):

iirc crater does indeed use debug mode

Pietro Albini (Oct 25 2019 at 15:06, on Zulip):

you can add custom rustflags anyway

eddyb (Oct 25 2019 at 15:06, on Zulip):

because I'm messing around with that, and I'm worried some sanity checks will get tripped in the wild

centril (Oct 25 2019 at 15:06, on Zulip):

@eddyb maybe we want crater runs for something const / promotion related?

centril (Oct 25 2019 at 15:07, on Zulip):

maybe we could run the old/new pass in a crater run

centril (Oct 25 2019 at 15:07, on Zulip):

cc @ecstatic-morse

eddyb (Oct 25 2019 at 15:07, on Zulip):

@centril we already did one of those recently, at least for my old/new :P

centril (Oct 25 2019 at 15:07, on Zulip):

oh we did?

eddyb (Oct 25 2019 at 15:07, on Zulip):

but yeah, we should've done it for @ecstatic-morse's validator too

centril (Oct 25 2019 at 15:07, on Zulip):

yeah I mean morse's validator

Pietro Albini (Oct 25 2019 at 15:07, on Zulip):

(we should probably just setup monitoring to page @eddyb when crater is idle)

eddyb (Oct 25 2019 at 15:08, on Zulip):

@centril my PR that's in the queue, about promotion, that waited for a while on a crater run

eddyb (Oct 25 2019 at 15:09, on Zulip):

@Pietro Albini hmm did we ever do a crater run for -Zsymbol-mangling-version=v0? oh yeah we did cause we found some weird crates using the backtrace crate on themselves to reflect a module/function path

Pietro Albini (Oct 25 2019 at 15:10, on Zulip):

not sure :sweat_smile:

centril (Oct 25 2019 at 15:15, on Zulip):

hmm; I looked through all the PRs but didn't feel I wanted to crater run anything in particular

centril (Oct 25 2019 at 15:16, on Zulip):

@nikomatsakis maybe you want to do a run on your leak-check stuff?

nikomatsakis (Oct 25 2019 at 18:31, on Zulip):

@centril I was thinking of coming back to that today -- uh -- yeah, good ida!

nikomatsakis (Oct 25 2019 at 18:31, on Zulip):

I think the PR is in a state where it could be cratered

nikomatsakis (Oct 25 2019 at 18:31, on Zulip):

well, why don't I rebase it I guess

simulacrum (Oct 25 2019 at 18:34, on Zulip):

crater is for try runs which will rebase for you :)

simulacrum (Oct 25 2019 at 18:34, on Zulip):

(presuming no conflicts)

nikomatsakis (Oct 25 2019 at 18:35, on Zulip):

lotsa conflicts

nikomatsakis (Oct 25 2019 at 18:35, on Zulip):

rebasing shouldn't take that long

ecstatic-morse (Oct 25 2019 at 18:51, on Zulip):

Is it possible to do a crater run that compares the parent of #64470 with a combination of #64470 and #65389? (I'd need to create a try build that contains the latter two). I think the bug that was fixed by #65389 will come up quite often and maybe make it tough to find new bugs.

ecstatic-morse (Oct 25 2019 at 18:51, on Zulip):

But yes! We should do this.

simulacrum (Oct 25 2019 at 19:01, on Zulip):

@ecstatic-morse it should be possible to make crater compare any two bors commits -- I can run the command if you ping me here or whereever

ecstatic-morse (Oct 25 2019 at 19:03, on Zulip):

@simulacrum I will have to create a new bors commit that is #64470 with #65389 cherry picked on it. Will bors complain about merge conficts when I try to schedule a try build since these commits are weeks old?

simulacrum (Oct 25 2019 at 19:04, on Zulip):

uh, probably? you can -- if necessary -- try to revert all the needed commits on your PR or w/e

simulacrum (Oct 25 2019 at 19:04, on Zulip):

or we can generate 1-2 separate try builds now with the relevant changes

ecstatic-morse (Oct 25 2019 at 19:04, on Zulip):

Okay, I'll try some stuff. I could just run it on everything between, but there might be some unrelated regressions in there.

simulacrum (Oct 25 2019 at 19:05, on Zulip):

I don't have time to deal with the generation of the try builds but I can run the final crater if you don't have the permissions (not sure, you might)

ecstatic-morse (Oct 25 2019 at 19:08, on Zulip):

kk. I'll ping you (I think I'm still not on the crater list)

ecstatic-morse (Oct 25 2019 at 19:30, on Zulip):
git diff --shortstat master
 2032 files changed, 27656 insertions(+), 36897 deletions(-)
ecstatic-morse (Oct 25 2019 at 19:31, on Zulip):

I now know how a 10x developer feels

ecstatic-morse (Oct 25 2019 at 21:57, on Zulip):

@simulacrum Will broken links in updated submodules cause a try build to fail?

ecstatic-morse (Oct 25 2019 at 21:57, on Zulip):

https://github.com/rust-lang/rust/pull/65829#issuecomment-546525773

ecstatic-morse (Oct 25 2019 at 21:58, on Zulip):

I guess there's some links directly to https://doc.rust-lang.org/nightly/ that have become outdated

ecstatic-morse (Oct 25 2019 at 22:14, on Zulip):

Disregard the above. crater queue is no longer empty.

simulacrum (Oct 25 2019 at 22:55, on Zulip):

broken links should be fine

simulacrum (Oct 25 2019 at 22:55, on Zulip):

crater queue is empty enough

ecstatic-morse (Oct 26 2019 at 03:48, on Zulip):

My crater experiment is progressing so fast that I fear something has gone terribly wrong :smile:

ecstatic-morse (Oct 26 2019 at 03:49, on Zulip):

20% after 5 hours can't be right, even distributed across two agents

simulacrum (Oct 26 2019 at 12:37, on Zulip):

Looks like metrics show that we've slowed down since then

simulacrum (Oct 26 2019 at 12:38, on Zulip):

we're still averaging ~70 jobs/minute across the run, ~40 jobs/minute in the last hour

simulacrum (Oct 26 2019 at 12:42, on Zulip):

the one run I sampled seemed to go fine

Last update: Nov 22 2019 at 05:30UTC