Stream: t-compiler

Topic: codeowners


davidtwco (Oct 26 2018 at 15:47, on Zulip):

Has Rust ever tried to set up a CODEOWNERS file?

oli (Oct 26 2018 at 15:49, on Zulip):

that sounds cool

Pietro Albini (Oct 26 2018 at 17:00, on Zulip):

hmm, that would duplicate the information in highfive's configuration file

Pietro Albini (Oct 26 2018 at 17:00, on Zulip):

which is the one actually used to make decisions about who gets assigned to the PR

Pietro Albini (Oct 26 2018 at 17:00, on Zulip):

it would be interesting to migrate highfive to use it

nagisa (Oct 26 2018 at 17:10, on Zulip):

Unlike with LLVM, where parts of code are fairly independent, and are expected to be maintained by the person who initially contributed some feature (backend, optimisation etc)… I don’t think it applies very well to Rust

nagisa (Oct 26 2018 at 17:11, on Zulip):

I wouldn’t like to maintain such a file at all. Would rather a heuristic that uses e.g. blame from surrounding code (which is a similar heuristic to what we use today?)

Pietro Albini (Oct 26 2018 at 17:13, on Zulip):

I think highfive just considers which team owns a directory

Pietro Albini (Oct 26 2018 at 17:14, on Zulip):

this should be it https://github.com/rust-lang-nursery/highfive/blob/master/highfive/configs/rust.json

Pietro Albini (Oct 26 2018 at 17:15, on Zulip):

I think CODEOWNERS supports setting teams as owners, so that could help us manage it

Pietro Albini (Oct 26 2018 at 17:16, on Zulip):

maybe creating teams like @rust-lang/rustc-review-borrowck to assign to specific parts of the codebase

davidtwco (Oct 26 2018 at 17:16, on Zulip):

There's already @wg-compiler-nll that could be used for some things.

davidtwco (Oct 26 2018 at 17:16, on Zulip):

(for example)

Pietro Albini (Oct 26 2018 at 17:21, on Zulip):

I don't think all the members of that WG have r+ rights though

davidtwco (Oct 26 2018 at 17:50, on Zulip):

That’s true. But they might want to review anyway?

Pietro Albini (Oct 26 2018 at 17:59, on Zulip):

I don't think it's useful to assign a PR to someone who can't approve it

nikomatsakis (Oct 26 2018 at 18:02, on Zulip):

I'm not a big fan of having to modify the main rust repo for this

nikomatsakis (Oct 26 2018 at 18:03, on Zulip):

though one thing I would like is some sort of bot to let people add themselves to the rust org so we can assign them to issues

nikomatsakis (Oct 26 2018 at 18:03, on Zulip):

(extending highfive seems good tho)

davidtwco (Oct 26 2018 at 18:19, on Zulip):

Zulip have a bot that lets people assign themselves. Not sure if it needs to add them to the org.

nikomatsakis (Oct 26 2018 at 18:20, on Zulip):

GH doesn't permit you to be assigned to an issue unless you belong to the org

nikomatsakis (Oct 26 2018 at 18:20, on Zulip):

I know some other teams at mozilla do this too

nikomatsakis (Oct 26 2018 at 18:20, on Zulip):

GH doesn't permit you to be assigned to an issue unless you belong to the org

one of the things I find most annoying about GH, btw :)

davidtwco (Oct 26 2018 at 18:20, on Zulip):

I assume their bot adds people to the org then.

nikomatsakis (Oct 26 2018 at 18:21, on Zulip):

yeah, presumably

davidtwco (Oct 26 2018 at 18:23, on Zulip):

https://github.com/zulip/zulipbot/blob/master/.github/README.md

nikomatsakis (Oct 26 2018 at 18:24, on Zulip):

ooh, yeah, we have needed some stuff like this forever

t allows anyone to perform issue triage (self-assigning and labeling issues), not just the core contributors trusted with full write access to the repository (which is the only model GitHub supports).

csmoe (Oct 26 2018 at 20:06, on Zulip):

recalling from my previous trip with github-api, GH seems have a limitation on admin/member ninvitations per day.
https://zulip.readthedocs.io/en/latest/contributing/zulipbot-usage.html
zulipbot gives the assign/label permission by inviting a new contributor as a collaborator.

this reminds me of: could the team maintain a list of Gandalf in certain topic? as far as I know(maybe not), like diagnosis's estebank, rust-llvm's nagisa, etc. it'll be easier for newcomers to get helps.
And while an issue is @bot claimed, then the bot can guide the assigned collaborator to the right wg-team based on the label like:
if any help needed, feel free to post for help in xx-team(https://team-chat-link).

Last update: Nov 20 2019 at 01:10UTC