Stream: t-compiler

Topic: tidy should not traverse untracked directories #69291


pnkfelix (Feb 27 2020 at 20:56, on Zulip):

@simulacrum what do you think of PR #69527 ?

simulacrum (Feb 27 2020 at 21:10, on Zulip):

hm

simulacrum (Feb 27 2020 at 21:10, on Zulip):

if it works I'm all for it I think

pnkfelix (Feb 27 2020 at 21:10, on Zulip):

the only problem I could imagine with this strategy

simulacrum (Feb 27 2020 at 21:10, on Zulip):

presuming it's not a massive slowdown?

pnkfelix (Feb 27 2020 at 21:10, on Zulip):

is if you add a lot of untracked files

pnkfelix (Feb 27 2020 at 21:11, on Zulip):

then presumably we'll do some amount of unnecessary work

simulacrum (Feb 27 2020 at 21:11, on Zulip):

eh, I think it's probably not too bad

simulacrum (Feb 27 2020 at 21:11, on Zulip):

I'm going to approve it

pnkfelix (Feb 27 2020 at 21:12, on Zulip):

I too expect that this will not matter in practice. Especially since I'm not doing git status --untracked=all.

simulacrum (Feb 27 2020 at 21:12, on Zulip):

Did you consider

       files. Because it takes extra work to find untracked files in the filesystem, this
       mode may take some time in a large working tree. Consider enabling untracked cache
       and split index if supported (see git update-index --untracked-cache and git
       update-index --split-index), Otherwise you can use no to have git status return
       more quickly without showing untracked files.
simulacrum (Feb 27 2020 at 21:13, on Zulip):

I guess if it's taking a long time we can presumably tell people to use that

pnkfelix (Feb 27 2020 at 21:41, on Zulip):

I was unaware of the --untracked-cache option. And yes, if someone actually complains about this in the wild, then we can put something in (e.g. emit a warning if the set of untracked files we add is huge)

simulacrum (Feb 27 2020 at 21:51, on Zulip):

mhm. rustfmt is already pretty slow (mostly because we're running it on every file individually, I think, though unsure), so I think this is not that big a deal

Last update: Jun 04 2020 at 18:35UTC