@nikomatsakis I wonder if we can replace MIR tests with regular UI ones. the MIR test implementation is incredibly frustrating
so they'd emit
.mir files instead of
.stderr files but generally behave the same?
hmm I was thinking just making it
stdout but maybe you're right
We could even make it emit multiple
.mir files (one per passes). Maybe comments in the
.rs file could decide which passes to dump
hmm oh right we'd need things like
once I'm done with https://github.com/rust-lang/rust/pull/56244 I'll have a look at that
I think that sounds great, but
we do want some way to specify precisely what we are looking for
I agree that the tests are annoying as is
I'm just thinking of the
//~ ERROR vs
ERROR serves to ensure that the contents of stderr are at least roughly correct, and also lets you encode a bit of the message if you like
not sure if there is some way to get some of that for the mir tests?
I'd settle for using comments if we must though, I agree the workflow is very painful :)
// error-pattern: ... already exists and could work?
well, that wouldn't literally work for mir tests
Yeah, but something in that vein.
but I guess we could have some kind of pattern to search for
I can't think what else to do, not sure how successfully that can encode the interesting cases
some of those mir tests may want to just be removed