Stream: t-compiler

Topic: Trait object with non-static lifetime is accepted where sta


Santiago Pastorino (May 21 2020 at 20:57, on Zulip):

@nikomatsakis @pnkfelix this issue with the patch in #71896 applied do not compile and segfaults, instead it reports a proper error. So the patch would be fixing both P-critical issues.

Santiago Pastorino (May 21 2020 at 21:24, on Zulip):

I'm not really sure if I'd :tada: that much about this one :joy:

Santiago Pastorino (May 21 2020 at 21:26, on Zulip):

if you're interested read more deeply the issue that my PR links and all the problems around the PR

pnkfelix (May 22 2020 at 13:56, on Zulip):

We haven't resolved what to do about that PR

pnkfelix (May 22 2020 at 13:56, on Zulip):

in terms of the regressions it injects, right?

Santiago Pastorino (May 22 2020 at 15:01, on Zulip):

yep

nikomatsakis (May 22 2020 at 18:47, on Zulip):

ugh let me look into the remaining issues there

nikomatsakis (May 22 2020 at 18:59, on Zulip):

OK, so, so far only 1 would be "truly" unsound

nikomatsakis (May 22 2020 at 19:00, on Zulip):

although I can't quite tell what the heck is going on with attr-1.0

nikomatsakis (May 22 2020 at 19:00, on Zulip):

oh I bet it's something very similar to the first one

nikomatsakis (May 22 2020 at 19:14, on Zulip):

OK so basically we have a few key traits where this is coming up

nikomatsakis (May 22 2020 at 19:14, on Zulip):

dyn Future<...>, dyn Stream, dyn Iterator

nikomatsakis (May 22 2020 at 19:15, on Zulip):

I have to say that the only fix I see for this would be fairly involved

nikomatsakis (May 22 2020 at 19:15, on Zulip):

There might be a way to do a warning period

nikomatsakis (May 22 2020 at 19:15, on Zulip):

Though that too would be fairly involved

nikomatsakis (May 22 2020 at 19:21, on Zulip):

I hate making calls like this :)

nikomatsakis (May 22 2020 at 19:23, on Zulip):

comment summarizing the above

Santiago Pastorino (May 22 2020 at 20:45, on Zulip):

:+1:

Santiago Pastorino (May 22 2020 at 20:46, on Zulip):

going to place a reminder for this right after the release

Last update: May 29 2020 at 18:00UTC