Stream: t-compiler

Topic: pre-meeting triage 2019-07-04 #54818


pnkfelix (Jul 04 2019 at 12:16, on Zulip):

I will be doing pre-triage in this channel.

pnkfelix (Jul 04 2019 at 12:21, on Zulip):

first up: we have 11 unprioritized I-nominated T-compiler issues

centril (Jul 04 2019 at 12:22, on Zulip):

2 soundness holes in a week... nice..

pnkfelix (Jul 04 2019 at 12:41, on Zulip):

somehow I got distracted and lost 30 minutes just now

pnkfelix (Jul 04 2019 at 12:41, on Zulip):

anyway, first up

pnkfelix (Jul 04 2019 at 12:42, on Zulip):

nominated unprioritized: "Hangs on derive macro invoked by format string macro" #44692

pnkfelix (Jul 04 2019 at 12:44, on Zulip):

This stable-to-stable regression is spawned off a bug that was originally thought to not be a rustc bug. But this narrower test case seems to be more definitively our problem. Looks P-high to me. I'll assign to petrochenkov and myself for initial investigation, and remove the nomination.

pnkfelix (Jul 04 2019 at 12:45, on Zulip):

(my hope is that some eventually revision to my pre-triage process will lead me to actually looking at all the P-high bugs, not just nominated or unassigned ones, which would then lead to me not assigning myself to these tickets.)

pnkfelix (Jul 04 2019 at 12:46, on Zulip):

next nominated unprioritized: "Static cyclic references not compiled in current nightly rust version" #62189

pnkfelix (Jul 04 2019 at 12:48, on Zulip):

This stable-to-nightly (soon to be beta) regression has been bisected to PR #58351 and identified as a const-eval issue. @oli stated that they would investigate, so I am assigning to them.

pnkfelix (Jul 04 2019 at 12:50, on Zulip):

As a note: My current thinking is that when I assign a (previously unassigned) bug to somehow who has already seemed to have "claimed" it (by e.g. saying they would take it, or chiming in on the ticket in a semi-authoritative manner), then I will just assign that one person. If that person has not claimed it, then I will assign myself as well to try to keep track of those cases.

pnkfelix (Jul 04 2019 at 12:50, on Zulip):

anyway: #62189, P-high, removing nomination, assign to @oli

pnkfelix (Jul 04 2019 at 12:51, on Zulip):

next nominated unprioritized: "Internal compiler error anonymous bound region BrAnon(0) in binding but not trait ref" #62200

pnkfelix (Jul 04 2019 at 12:52, on Zulip):

occurs on stable. checking if its always been present in some form, or if its a stable-to-stable regression

pnkfelix (Jul 04 2019 at 12:53, on Zulip):

(maybe we should have an actual label for bugs that have been present ever since their code could have been expressed?)

simulacrum (Jul 04 2019 at 12:57, on Zulip):

fwiw master->beta promotion happened last night, and first beta should be published in about 2-3 hours

pnkfelix (Jul 04 2019 at 12:59, on Zulip):

oh okay thanks @simulacrum !

simulacrum (Jul 04 2019 at 13:00, on Zulip):

(and 1.36 release just kicked off)

pnkfelix (Jul 04 2019 at 13:06, on Zulip):

regarding #62200, did some further investigation. Seems like a very very old bug. Going to call it P-medium for now. (and remove nomination and assign to self).

pnkfelix (Jul 04 2019 at 13:07, on Zulip):

next: "ICE on HRTB" #62203

pnkfelix (Jul 04 2019 at 13:08, on Zulip):

description claims bug occurs in stable+beta+nightly, but code to reproduce relies on feature(fn_traits) and feature(unboxed_closures). Did issue filer use RUSTC_BOOTSTRAP, or go back to nightlies that correspond to stable+beta, or ...?

simulacrum (Jul 04 2019 at 13:08, on Zulip):

I think the features aren't really being used?

simulacrum (Jul 04 2019 at 13:08, on Zulip):

Maybe for the FnMut<T> vs. FnMut(T)

simulacrum (Jul 04 2019 at 13:09, on Zulip):

er, <A>

pnkfelix (Jul 04 2019 at 13:09, on Zulip):

maybe

pnkfelix (Jul 04 2019 at 13:09, on Zulip):

oh oh

pnkfelix (Jul 04 2019 at 13:09, on Zulip):

the ICE occurs even after you get the warning about the features

pnkfelix (Jul 04 2019 at 13:09, on Zulip):

so never mind

pnkfelix (Jul 04 2019 at 13:09, on Zulip):

ICE is from librustc/infer/lexical_region_resolve.rs

simulacrum (Jul 04 2019 at 13:09, on Zulip):

https://play.rust-lang.org/?version=stable&mode=debug&edition=2015&gist=1428eecd0530823e372ce19cbe66afba works anyway

pnkfelix (Jul 04 2019 at 13:10, on Zulip):

I wounder if full blown NLL would fix it

simulacrum (Jul 04 2019 at 13:10, on Zulip):

nightly appears to have same ICE with feature(nll)

pnkfelix (Jul 04 2019 at 13:12, on Zulip):

ICE appears to have been injected between 1.32 and 1.33

pnkfelix (Jul 04 2019 at 13:13, on Zulip):

#62203: P-high, removing nomination. Assigning to self for now.

pnkfelix (Jul 04 2019 at 13:15, on Zulip):

next nominated unprioritized: "Nightly compiler panic on using Self with associated type in type alias" #62305

pnkfelix (Jul 04 2019 at 13:18, on Zulip):

#62305: P-high, needs-bisect, removing nomination, assigning to self. (It would be good to have an "owner" for each category like A-associated-items who could be delegated to for further delegation. Perhaps something to discuss at the triage/maintenance meeting, whenever that happens...)

pnkfelix (Jul 04 2019 at 13:19, on Zulip):

next nominated unprioritized: "Future compat warning with .awaiting a BoxFuture" #62312

pnkfelix (Jul 04 2019 at 13:19, on Zulip):

was already self-assigned by matthew-jasper. Given status of async-await as "important feature for near-term", I'll give this P-high status, and removing nominatin.

pnkfelix (Jul 04 2019 at 13:19, on Zulip):

(thanks @Matthew Jasper !)

pnkfelix (Jul 04 2019 at 13:20, on Zulip):

next nominated unprioritized: "clippy-driver no longer builds after rust-lang/rust#61995" #62338

pnkfelix (Jul 04 2019 at 13:21, on Zulip):

already automatically assigned by rust-highfive. Has PR thanks to @matthiaskrgr . Going to add them to the assignee list, and mark as P-medium.

pnkfelix (Jul 04 2019 at 13:22, on Zulip):

ah cannot add @matthiaskrgr . I need to double check, there's some other work flow we have in place for this, right? to delegate a bug or something? Or is that only for delegation of reviewing PR's?

centril (Jul 04 2019 at 13:23, on Zulip):

You can claim issues; idk if you can delegate; cc @simulacrum

simulacrum (Jul 04 2019 at 13:24, on Zulip):

@rustbot assign @gh-user

simulacrum (Jul 04 2019 at 13:24, on Zulip):

hm, that ended up clearing everyone

pnkfelix (Jul 04 2019 at 13:24, on Zulip):

ah that removes previous assignees too. I see, and then assigns rustbot.

pnkfelix (Jul 04 2019 at 13:24, on Zulip):

what does that mean then?

simulacrum (Jul 04 2019 at 13:25, on Zulip):

see first comment -- it has "@matthiaskrgr is assigned in [this comment]"

pnkfelix (Jul 04 2019 at 13:25, on Zulip):

I assume we have a separate web page I go to in order to see who's been assigned in this manner?

simulacrum (Jul 04 2019 at 13:25, on Zulip):

This issue has been assigned to @matthiaskrgr via this comment.

pnkfelix (Jul 04 2019 at 13:25, on Zulip):

ah okay

pnkfelix (Jul 04 2019 at 13:25, on Zulip):

that'll work well enough, since rustbot is assigned and that will show up in the github issue list etc, thanks.

pnkfelix (Jul 04 2019 at 13:26, on Zulip):

next nominated unprioritized: "miri no longer builds after rust-lang/rust#62335" #62347

centril (Jul 04 2019 at 13:26, on Zulip):

Seems handled

pnkfelix (Jul 04 2019 at 13:27, on Zulip):

#62347: P-medium, assign to @RalfJ who has a PR (#62245) that is supposed to handle it.

pnkfelix (Jul 04 2019 at 13:28, on Zulip):

next nominated unprioritized: "FFI broken with many parameters" #62350

pnkfelix (Jul 04 2019 at 13:29, on Zulip):

already assigned to @eddyb

pnkfelix (Jul 04 2019 at 13:29, on Zulip):

#62350: P-high, removing nomination.

pnkfelix (Jul 04 2019 at 13:30, on Zulip):

next nominated unprioritized: "ICE: rustc crashes in a chroot sandbox" #62353

pnkfelix (Jul 04 2019 at 13:32, on Zulip):

this is arising from rustc::session::filesearch::get_or_default_sysroot, on this line

pnkfelix (Jul 04 2019 at 13:35, on Zulip):

hmm. At first I was thinking "can we do anything about this", but surely we could let our users specify a sysroot if they are running in an environment where they cannot rely on std::env::current_eye returning Ok

pnkfelix (Jul 04 2019 at 13:36, on Zulip):

It seems like an interesting bug to tackle, but not a high priority one.

pnkfelix (Jul 04 2019 at 13:36, on Zulip):

#62353: P-medium, leaving nominated to discuss at meeting (to see if anyone wants to take it or mentor someone else on how to address it).

pnkfelix (Jul 04 2019 at 13:39, on Zulip):

next nominated unprioritized: "ICE on self-referential typedef" #62364

pnkfelix (Jul 04 2019 at 13:41, on Zulip):

recent regression, about to hit beta (or already hit beta, depending on POV as noted earlier).

pnkfelix (Jul 04 2019 at 13:41, on Zulip):

#62364: P-high, removing nomination. Assigning to @Alexander Regueiro and self to ensure follow-up.

pnkfelix (Jul 04 2019 at 13:43, on Zulip):

okay, that is all the nominated unprioritized T-compiler issues.

pnkfelix (Jul 04 2019 at 13:43, on Zulip):

there are zero nominated with no team assigned

pnkfelix (Jul 04 2019 at 13:43, on Zulip):

zero beta regressions without P-label

pnkfelix (Jul 04 2019 at 13:44, on Zulip):

one nightly regression without P-label

pnkfelix (Jul 04 2019 at 13:44, on Zulip):

which is "ICE "not a type parameter" on nightly (regression)" #62263

pnkfelix (Jul 04 2019 at 13:45, on Zulip):

we have 44 P-high T-compiler issues

pnkfelix (Jul 04 2019 at 13:46, on Zulip):

8 of those are unassigned

pnkfelix (Jul 04 2019 at 13:46, on Zulip):

I'm going to go afk for hopefully a short time, and hopefully return in time to try to assign these 8 issues to people that may or may not include me.

pnkfelix (Jul 04 2019 at 13:56, on Zulip):

unassigned P-high: "Running cargo test with proc macro that uses main fails" #62127

pnkfelix (Jul 04 2019 at 13:57, on Zulip):

@Vadim Petrochenkov has been pretty involved with dialogue on this one. (They also have stated that the bug, or some variant of it, may be hard to fix. Not sure what the final status is.)

pnkfelix (Jul 04 2019 at 13:57, on Zulip):

#62127: assigning to @Vadim Petrochenkov

pnkfelix (Jul 04 2019 at 13:58, on Zulip):

next unassigned P-high: "Rustdoc recursion limit issue" #62059

pnkfelix (Jul 04 2019 at 13:58, on Zulip):

ah I said last week I was assigning this to @nagisa and then failed to do so.

pnkfelix (Jul 04 2019 at 13:59, on Zulip):

but @nagisa did note that they were unlikely to have time to address it soon

pnkfelix (Jul 04 2019 at 13:59, on Zulip):

so I'll assign it now to @nagisa and myself.

pnkfelix (Jul 04 2019 at 14:00, on Zulip):

next unassigned P-high: "ICE when running kcov with proptest as dev-dependency" #60372

pnkfelix (Jul 04 2019 at 14:01, on Zulip):

#60372: assigning to self

pnkfelix (Jul 04 2019 at 14:02, on Zulip):

next unassigned P-high: "Compiler panic at Box<Any>" #60363

pnkfelix (Jul 04 2019 at 14:02, on Zulip):

there's been some dialogue on ticket

pnkfelix (Jul 04 2019 at 14:02, on Zulip):

#60363: assigning to @oli and mysefl.

pnkfelix (Jul 04 2019 at 14:03, on Zulip):

lets take care of one more, to get everything from this yeasr assigned:

pnkfelix (Jul 04 2019 at 14:03, on Zulip):

P-high unassigned: "Stable rustc always panics on arm/musl" #60297

pnkfelix (Jul 04 2019 at 14:03, on Zulip):

actually I'll just nominate it and see if someone at the meeting is willingto take it.

Last update: Nov 22 2019 at 05:00UTC