Stream: t-compiler

Topic: alignment increasing patch


nagisa (Nov 27 2018 at 21:49, on Zulip):

@eddyb I remember we landed some code that icnreased alignment of structure field projections based on the structure itself, right?

nagisa (Nov 27 2018 at 21:50, on Zulip):

do you happen to remember in which compiler version that ended up being?

nagisa (Nov 27 2018 at 21:50, on Zulip):

because that’s most likely a culprit of https://github.com/rust-lang/rust/issues/56267 that I can think of

nagisa (Nov 27 2018 at 21:50, on Zulip):

cc @Nikita Popov ^ :slight_smile:

Nikita Popov (Nov 27 2018 at 22:03, on Zulip):

@nagisa I think I found the culprit: https://github.com/rust-lang/rust/issues/56267#issuecomment-442233210

Nikita Popov (Nov 27 2018 at 22:04, on Zulip):

That code probably ought to be using project_field

eddyb (Nov 27 2018 at 22:21, on Zulip):

no, there's no correspondence to fields

eddyb (Nov 27 2018 at 22:22, on Zulip):

just have to call restrict_for_offset

eddyb (Nov 27 2018 at 22:33, on Zulip):

@Nikita Popov @nagisa left a comment on-thread

eddyb (Nov 27 2018 at 22:34, on Zulip):

is beta frozen already?

simulacrum (Nov 27 2018 at 23:17, on Zulip):

beta is "frozen" in that we would prefer not to land any major work, but if something absolutely must get in, then it can

Last update: Nov 16 2019 at 01:05UTC