Stream: t-compiler

Topic: rustc-guides-stages


Santiago Pastorino (Apr 17 2019 at 14:35, on Zulip):

@Iñaki Garay let's talk here

Santiago Pastorino (Apr 17 2019 at 14:36, on Zulip):

so, I was saying

Santiago Pastorino (Apr 17 2019 at 14:36, on Zulip):

about https://github.com/rust-lang/rustc-guide/pull/301

Santiago Pastorino (Apr 17 2019 at 14:36, on Zulip):

please, squash commits and make separate PRs for the stages docs and for the broken links

Santiago Pastorino (Apr 17 2019 at 14:37, on Zulip):

leave https://github.com/rust-lang/rustc-guide/pull/301 for the stages documentation

Iñaki Garay (Apr 17 2019 at 14:38, on Zulip):

roger!

Iñaki Garay (Apr 18 2019 at 00:15, on Zulip):

Is the travis build failing expected? Looking at the build output from https://travis-ci.com/rust-lang/rustc-guide/builds/108764339 it looks like it's trying to compile the sample output text enclosed in triple backticks. I'll add a bash qualifier to the section while I add the additional discussion in https://github.com/rust-lang/rust/issues/57963#issuecomment-458429280 but correct me preemptively if I'm wrong.

Iñaki Garay (Apr 19 2019 at 18:03, on Zulip):

Just an update. Addressed PR comments but still rewording the discussion on issue 57963.

Iñaki Garay (Apr 25 2019 at 22:26, on Zulip):

This https://github.com/rust-lang/rustc-guide/pull/307 has to be merged before I can rebase and send the newest additions.

Santiago Pastorino (Apr 25 2019 at 22:27, on Zulip):

@Iñaki Garay something is wrong in the PR, the title is about broken links but there is a commit about the stages

Santiago Pastorino (Apr 25 2019 at 22:27, on Zulip):

I guess I'd split those and just provide the links commits in that PR

Santiago Pastorino (Apr 25 2019 at 22:27, on Zulip):

or what was your idea?

Iñaki Garay (Apr 25 2019 at 22:28, on Zulip):

hmmm you're right

Iñaki Garay (Apr 25 2019 at 22:28, on Zulip):

how did that get in there?

Iñaki Garay (Apr 25 2019 at 22:32, on Zulip):

ah, my GH master has bad commits in it, fixing

Iñaki Garay (Apr 25 2019 at 22:34, on Zulip):

that's more like it, fixed @Santiago Pastorino

Santiago Pastorino (Apr 25 2019 at 22:39, on Zulip):

:+1:

Santiago Pastorino (Apr 25 2019 at 22:39, on Zulip):

I don’t have commit access so can’t merge it

Iñaki Garay (Apr 25 2019 at 22:41, on Zulip):

Travis is still failing because of another unrelated error. mdbook test is failing because of the two phase borrow changes.

Iñaki Garay (Apr 25 2019 at 22:43, on Zulip):

This is the code snippet https://github.com/rust-lang/rustc-guide/pull/305/files#diff-5311fe548c2eb1bbb4b4ab3ca2151676R18

I'm not sure whether the example code needs to be fixed or simply marked as ignore

Iñaki Garay (Apr 25 2019 at 22:53, on Zulip):

I see, the example code didn't compile with my outdated (rustc 1.36.0-nightly (33fe1131c 2019-04-20)) nightly compiler but it did after I ran rustup update (with rustc 1.36.0-nightly (e305df184 2019-04-24))

So I guess it's just a matter of waiting for the CI toolchain to be updated (how does that happen? manooallee? automagically?) and not ignoreing the snippet

Iñaki Garay (Apr 29 2019 at 23:59, on Zulip):

PR finally updated. I swear the wait between submission and review feels like waiting for college grades all over again xD

Santiago Pastorino (Apr 30 2019 at 13:21, on Zulip):

@Iñaki Garay I don't know if people care that much, but I'd split in 2 commits, one the markdown/style fixes and another one with the real content

Santiago Pastorino (Apr 30 2019 at 13:21, on Zulip):

makes things cleaner and easier to review in general

Santiago Pastorino (Apr 30 2019 at 14:10, on Zulip):

left some comments

Last update: Nov 16 2019 at 01:05UTC