Stream: t-compiler

Topic: gdb/lldb pretty printers #60826


nikomatsakis (Jul 12 2019 at 11:04, on Zulip):

So I'm inclined to just r+ https://github.com/rust-lang/rust/pull/60826... any thoughts @T-compiler? It's a PR that improves the gdb/lldm pretty printers, which I think don't really have an owner right now? The changes all look good to me -- maybe we could request more tests, I suppose.

eddyb (Jul 12 2019 at 11:05, on Zulip):

debuginfo tests have been broken for a long while in a few ways I think :(

eddyb (Jul 12 2019 at 11:05, on Zulip):

but I think you can r+ that PR

eddyb (Jul 12 2019 at 11:05, on Zulip):

if someone complains we can revert it

eddyb (Jul 12 2019 at 11:06, on Zulip):

maybe tell the PR opener to open a forum post telling people to try the new pretty printers out

eddyb (Jul 12 2019 at 11:06, on Zulip):

once it lands in nightly

nikomatsakis (Jul 12 2019 at 11:08, on Zulip):

not a bad idea, can you post on the PR? gotta run right now

Last update: Nov 16 2019 at 02:15UTC