Stream: t-compiler

Topic: rustc-rayon


nikomatsakis (Jan 31 2019 at 14:22, on Zulip):

@Zoxc @mw I'm looking at https://github.com/Zoxc/rayon/pull/2/, but I was wondering -- why isn't this a PR against https://github.com/rust-lang-nursery/rustc-rayon ?

Zoxc (Jan 31 2019 at 14:24, on Zulip):

Either I didn't know about that repo, or I forgot about it =P

nikomatsakis (Jan 31 2019 at 14:26, on Zulip):

Heh, ok

nikomatsakis (Jan 31 2019 at 14:29, on Zulip):

Oh, also, it seems like https://crates.io/crates/rustc-rayon is owned by you, @Zoxc, but we should add https://github.com/orgs/rust-lang/teams/compiler as an owner -- probably core/release too. (We don't actually have a clear policy here...)

nikomatsakis (Jan 31 2019 at 14:29, on Zulip):

I think though you're the only one that can do that right now =)

Zoxc (Jan 31 2019 at 14:36, on Zulip):

That repo should probably be forked from upstream rayon, instead of my fork too

nikomatsakis (Jan 31 2019 at 14:43, on Zulip):

/me shrugs

nikomatsakis (Jan 31 2019 at 14:43, on Zulip):

Probably =) but I'm not sure that's something we can change... doesn't matter much I guess?

nikomatsakis (Jan 31 2019 at 14:44, on Zulip):

(Can you adjust that manually?)

nikomatsakis (Jan 31 2019 at 14:44, on Zulip):

I think we could email github support, I guess

nikomatsakis (Jan 31 2019 at 14:44, on Zulip):

PS, @Zoxc, I left a review

Zoxc (Jan 31 2019 at 14:45, on Zulip):

Probably easier to just steal your single commit into my fork and remake it =P

nikomatsakis (Jan 31 2019 at 14:45, on Zulip):

Hopefully we can get rid of the fork anyway :)

nikomatsakis (Jan 31 2019 at 14:45, on Zulip):

Which reminds me

nikomatsakis (Jan 31 2019 at 14:45, on Zulip):

I'd like to have a write-up of exactly what differs from upstream rayon

nikomatsakis (Jan 31 2019 at 14:45, on Zulip):

I tried to do such a write-up at some point, but I think it was incomplete

nikomatsakis (Jan 31 2019 at 14:46, on Zulip):

I'm imagining mostly a "bullet list" more than anything

nikomatsakis (Jan 31 2019 at 14:46, on Zulip):

Do you think you could easily create such a thing? Otherwise, I can take a stab at it and send it to you to take a look at

Zoxc (Jan 31 2019 at 16:27, on Zulip):

@nikomatsakis Do you have permissions to delete https://github.com/rust-lang-nursery/rustc-rayon?

Zoxc (Jan 31 2019 at 16:36, on Zulip):

Also does liking the callbacks equal approval? If so I'll make a new rustc-rayon release =P

nikomatsakis (Jan 31 2019 at 18:17, on Zulip):

@Zoxc I think I can delete that, yeah, are you thinking of transferring your fork over?

nikomatsakis (Jan 31 2019 at 18:17, on Zulip):

(Do you have all the commits?)

nikomatsakis (Jan 31 2019 at 18:17, on Zulip):

Also does liking the callbacks equal approval? If so I'll make a new rustc-rayon release =P

and yes I approve

Zoxc (Jan 31 2019 at 18:18, on Zulip):

Just delete it and make a fresh fork from upstream Rayon. I cherry picked your README change you applied to the fiber branch =P

nikomatsakis (Jan 31 2019 at 18:18, on Zulip):

ok

nikomatsakis (Jan 31 2019 at 18:19, on Zulip):

@Zoxc I created https://github.com/rust-lang/rustc-rayon

nikomatsakis (Jan 31 2019 at 18:19, on Zulip):

note the change in org

nikomatsakis (Jan 31 2019 at 18:20, on Zulip):

Also, all members of compiler team should have access.

nagisa (Jan 31 2019 at 18:28, on Zulip):

why is this a fork?

nagisa (Jan 31 2019 at 18:28, on Zulip):

I guess I should phrase my question like this:

nagisa (Jan 31 2019 at 18:28, on Zulip):

why are we not working upstream? Ain’t that essentially niko’s project anyway?

nagisa (Jan 31 2019 at 18:29, on Zulip):

From what I understand whatever we would end up wanting in rustc-rayon would very much be beneficial to the wider ecosystem as well.

nagisa (Jan 31 2019 at 18:30, on Zulip):

e.g. jobserver support (possibly general version that enables user code to do so), custom thread creation (currently, I believe you cannot do that)

nikomatsakis (Jan 31 2019 at 18:32, on Zulip):

@nagisa the plan is to eventually merge some things upstream

nikomatsakis (Jan 31 2019 at 18:32, on Zulip):

that is the point of the breakout topic, though I am not sure we'll get to this at the all hands

nikomatsakis (Jan 31 2019 at 18:32, on Zulip):

but basically we decided to fork for now and sift it out later

nagisa (Jan 31 2019 at 18:32, on Zulip):

Okay, I guess I’ll rephrase it again: I really dislike the split between rustc-* things and the upstream things.

nikomatsakis (Jan 31 2019 at 18:32, on Zulip):

later being "soon" :)

nagisa (Jan 31 2019 at 18:32, on Zulip):

I’d rather we avoided that as much as it is feasible.

Zoxc (Jan 31 2019 at 18:33, on Zulip):

@nikomatsakis The commit list is a nice list of changes in the fork - https://github.com/rust-lang/rustc-rayon/commits/crate-0.1.2

Last update: Nov 20 2019 at 02:10UTC