Stream: t-compiler

Topic: Moving treat-err-as-bug tests to UI


Santiago Pastorino (Apr 24 2020 at 20:35, on Zulip):

have created this #71531 to move the only treat-err-as-bug test we have to UI

Santiago Pastorino (Apr 24 2020 at 20:36, on Zulip):

as I've explained there I'm not sure if it's a good idea to run it with BACKTRACE=1

pnkfelix (Apr 24 2020 at 20:37, on Zulip):

are there normalization rules you could apply to fix that?

pnkfelix (Apr 24 2020 at 20:37, on Zulip):

(to remove the host specific information from the stack trace, that is)

pnkfelix (Apr 24 2020 at 20:41, on Zulip):

Look for normalize-stdout-test and normalize-stderr-test in the current set of UI tests to see examples of what I am referring to.

Santiago Pastorino (Apr 24 2020 at 20:42, on Zulip):

ahh right

Santiago Pastorino (Apr 24 2020 at 20:42, on Zulip):

I think there's something

Santiago Pastorino (Apr 24 2020 at 20:54, on Zulip):

@pnkfelix I wonder how you discard stuff you catched in the regex

pnkfelix (Apr 24 2020 at 20:54, on Zulip):

? I think by just not including it?

pnkfelix (Apr 24 2020 at 20:54, on Zulip):

i.e. you could just map the whole line to OHNOE

Santiago Pastorino (Apr 24 2020 at 20:55, on Zulip):

yeah

Santiago Pastorino (Apr 24 2020 at 20:55, on Zulip):

hehe

Santiago Pastorino (Apr 24 2020 at 20:55, on Zulip):

so it's happening the opposite

Santiago Pastorino (Apr 24 2020 at 20:55, on Zulip):

everything is discarded

pnkfelix (Apr 24 2020 at 20:55, on Zulip):

see e.g. svh/svh-change-trait-bound.rs

Santiago Pastorino (Apr 24 2020 at 20:55, on Zulip):

// normalize-stderr-test "at /.*/src/backtrace/.*:[0-9]*" -> "src/backtrace/FILENAME:LL"

pnkfelix (Apr 24 2020 at 20:56, on Zulip):

Okay. so there's stuff you want included?

pnkfelix (Apr 24 2020 at 20:56, on Zulip):

for those things, enclose them in parenthesis in the pattern

pnkfelix (Apr 24 2020 at 20:56, on Zulip):

(again, see svh/svh-change-trait-bound.rs for an example)

Santiago Pastorino (Apr 24 2020 at 20:56, on Zulip):

ahh I see

pnkfelix (Apr 24 2020 at 20:57, on Zulip):

and then $1 for the first parenthesized thing, $2 for the second, etc

pnkfelix (Apr 24 2020 at 20:57, on Zulip):

this is a relatively standard thing for regexp's to support, and very useful

Santiago Pastorino (Apr 24 2020 at 20:58, on Zulip):

yeah, it's working

Santiago Pastorino (Apr 24 2020 at 20:58, on Zulip):

I've messed some stuff but it's ok now

Santiago Pastorino (Apr 24 2020 at 21:01, on Zulip):

#71531 is ready then

Santiago Pastorino (Apr 24 2020 at 21:01, on Zulip):

modulo CI being green

Last update: Jun 04 2020 at 18:35UTC