Stream: t-compiler

Topic: style changes


Alexander Regueiro (Jan 17 2019 at 17:16, on Zulip):

@pnkfelix @Wesley Wiser @nikomatsakis Let me know how you want to categorise changes and I’ll factor them out into separate commits.

Wesley Wiser (Jan 17 2019 at 18:21, on Zulip):

@Alexander Regueiro Just skimming through the first couple files in your PR, I'd like to see individual commits for each of these:

Any changes to code should definitely go in their own commits.

My 2c

Alexander Regueiro (Jan 17 2019 at 18:24, on Zulip):

@Wesley Wiser sounds reasonable. I'm going to implement the URL to issue number changes, since that represents the existing consensus in the codebase, but we can all debate later. Re true if, I'll normalise to that (even if I don't like it)

Wesley Wiser (Jan 17 2019 at 18:28, on Zulip):

@Alexander Regueiro The other thing that might help you get this done quicker is to split up the changes by module or whatever. ljedrz has taken this approach and it seems to have worked well for them: https://github.com/rust-lang/rust/pulls?utf8=%E2%9C%93&q=is%3Apr+author%3Aljedrz+cleanup

Wesley Wiser (Jan 17 2019 at 18:29, on Zulip):

People will be faster to review and approve smaller PRs than large ones

Alexander Regueiro (Jan 17 2019 at 18:32, on Zulip):

@Wesley Wiser okay, sounds fair, ta

nikomatsakis (Jan 17 2019 at 22:24, on Zulip):

(I broke out a topic for this)

varkor (Jan 18 2019 at 11:01, on Zulip):

(for the record, I think I'd prefer normalising issue numbers to URLs rather than vice versa, as they're more convenient to access)

Last update: Nov 20 2019 at 01:40UTC