Stream: t-compiler

Topic: PR 53821: move validation into const_eval query


RalfJ (Sep 30 2018 at 13:13, on Zulip):

I haven't heard back from anyone about https://github.com/rust-lang/rust/pull/53821 for more than a week. How do we proceed?

pnkfelix (Sep 30 2018 at 19:53, on Zulip):

the compiler team didn't manage to get through its whole agenda at the last meeting... let me see

pnkfelix (Sep 30 2018 at 19:54, on Zulip):

in terms of the issues you're having not being able to push to @Oli 's branch anymore, my personal appproach would be to close Oli's PR and open your own.

pnkfelix (Sep 30 2018 at 19:54, on Zulip):

(and have the latter PR reference the former)

RalfJ (Sep 30 2018 at 20:16, on Zulip):

well I was mostly asking for a decision

RalfJ (Sep 30 2018 at 20:16, on Zulip):

'cause reopening will get us at the end of the queue, and IIRC oli's going to be back some time next week

nagisa (Sep 30 2018 at 20:45, on Zulip):

Can always slap a p=1 on it

nikomatsakis (Oct 01 2018 at 17:21, on Zulip):

@RalfJ can you point at a comment that crystallizes the question being decided?

RalfJ (Oct 01 2018 at 17:28, on Zulip):

@nikomatsakis I just wrote one: https://github.com/rust-lang/rust/pull/53821#issuecomment-425993073

nikomatsakis (Oct 01 2018 at 17:50, on Zulip):

ah, right, I remember this now

Last update: Nov 22 2019 at 04:40UTC