Stream: t-compiler

Topic: queue is almost empty


centril (Mar 30 2019 at 17:26, on Zulip):

hey @T-compiler -- the bors queue is almost empty... y'all need to r+ some more :P

Zoxc (Mar 30 2019 at 17:26, on Zulip):

Haven't had that problem in a while

Esteban Küber (Mar 30 2019 at 17:27, on Zulip):

That's new

centril (Mar 30 2019 at 17:29, on Zulip):

its what you get when you don't have 259 problems and the power of rollups

Zoxc (Mar 30 2019 at 17:44, on Zulip):

@centril You can review https://github.com/rust-lang/rust/pull/59517 =P

centril (Mar 30 2019 at 17:45, on Zulip):

@Zoxc I can rubber stamp, I cannot review ;)

Zoxc (Mar 30 2019 at 17:45, on Zulip):

That doesn't sound right. Everyone can review, only the compiler team can rubber stamp? =P

Matthew Jasper (Mar 30 2019 at 17:46, on Zulip):

+1,274 −2,316 :thinking:

centril (Mar 30 2019 at 18:10, on Zulip):

@Zoxc @oli can review your PR tho ;)

oli (Mar 30 2019 at 18:11, on Zulip):

I still have 90 new notifications since yesterday, I may not get to reviews until tomorrow or tuesday

centril (Apr 01 2019 at 09:29, on Zulip):

I am pleased to say that the queue is entirely empty now and has been for hours.

Pietro Albini (Apr 01 2019 at 09:30, on Zulip):

all that wasted money :(

centril (Apr 01 2019 at 09:31, on Zulip):

Yeah; start r+ing folks

centril (Apr 01 2019 at 09:35, on Zulip):

@Pietro Albini perhaps this is a good time to rustfmt?

kennytm (Apr 01 2019 at 14:36, on Zulip):

perhaps revive #58702 first :upside_down:

centril (Apr 01 2019 at 15:13, on Zulip):

@kennytm waiting on boostrap changes

Vadim Petrochenkov (Apr 01 2019 at 17:12, on Zulip):

perhaps this is a good time to rustfmt?

By the way, the primary issue with trailing expressions that I was complaining about in https://internals.rust-lang.org/t/running-rustfmt-on-rust-lang-rust-and-other-rust-lang-repositories/8732/72 is fixed now (only in rustfmt 2.0 mode though).

Vadim Petrochenkov (Apr 01 2019 at 17:13, on Zulip):

(I still think this formatting thing needs a test run on a single crate though, to get experience with the process.)

Jake Goulding (Apr 01 2019 at 17:48, on Zulip):

only in rustfmt 2.0 mode

TIL — what is this?

Vadim Petrochenkov (Apr 01 2019 at 20:39, on Zulip):

@Jake Goulding
version = "Two" in rustfmt.toml

Vadim Petrochenkov (Apr 01 2019 at 20:40, on Zulip):

rustfmt attempts to avoid changing formatting in stable releases

Jake Goulding (Apr 01 2019 at 20:44, on Zulip):

Hm. It's not obviously documented on the README; is there somewhere more official I should be reading to learn about what settings that implies?

Jake Goulding (Apr 01 2019 at 20:45, on Zulip):

It's mentioned in https://github.com/rust-lang/rustfmt/blob/master/Configurations.md

Jake Goulding (Apr 01 2019 at 20:45, on Zulip):

Ugh. That should probably be exposed in the playground in some manner...

Last update: Nov 21 2019 at 13:45UTC