Stream: t-compiler

Topic: responsible T-labeling when beta-nominating


pnkfelix (Oct 10 2019 at 13:15, on Zulip):

the main issue is when we/I forget to actually look at the full list

centril (Oct 10 2019 at 13:15, on Zulip):

probably yes

nagisa (Oct 10 2019 at 13:15, on Zulip):

In my experience, no, however annoying lack of the tag might be.

pnkfelix (Oct 10 2019 at 13:15, on Zulip):

but it is on the agenda

centril (Oct 10 2019 at 13:15, on Zulip):

I have to cleanup other people's mistakes

pnkfelix (Oct 10 2019 at 13:15, on Zulip):

@centril what do you mean?

centril (Oct 10 2019 at 13:15, on Zulip):

@pnkfelix adding the t-compiler label on beta-nominated PRs

pnkfelix (Oct 10 2019 at 13:16, on Zulip):

but it doesn't have to fall on you

pnkfelix (Oct 10 2019 at 13:16, on Zulip):

the point of the relevant bullet on the Pre-triage Process page is that these mistakes are meant to be caught during pre-triage.

centril (Oct 10 2019 at 13:16, on Zulip):

guess not; I am on the release team so that is my job...

nikomatsakis (Oct 10 2019 at 13:16, on Zulip):

this seems like something a bot could help

nikomatsakis (Oct 10 2019 at 13:16, on Zulip):

@rustbot beta-nominate

nikomatsakis (Oct 10 2019 at 13:16, on Zulip):

something like that

centril (Oct 10 2019 at 13:17, on Zulip):

how does it know which team to nominate it for?

nikomatsakis (Oct 10 2019 at 13:17, on Zulip):

it could also complain if somebody adds a beta-nominated label without a T- flag

pnkfelix (Oct 10 2019 at 13:17, on Zulip):

this is not a good use of pre-triage time. Lets table debate about whether to email or not to sometime after the meeting today.

nagisa (Oct 10 2019 at 13:17, on Zulip):

not even that, just something that monitors tags being added and nags at you if you don’t add the other tags within 5 seconds.

pnkfelix (Oct 10 2019 at 13:17, on Zulip):

I'll move this conversation to a forked topic

centril (Oct 10 2019 at 13:18, on Zulip):

I'll put @nagisa's idea on the release team agenda instead

DPC (Oct 10 2019 at 13:25, on Zulip):

not even that, just something that monitors tags being added and nags at you if you don’t add the other tags within 5 seconds.

sounds like a job for the triage-wg :slight_smile: nevermind too early for that

Santiago Pastorino (Oct 10 2019 at 13:40, on Zulip):

/me doesn't know if we have an email list of all contributors, but he'll find out.

compiler-team@rust-lang.org

Santiago Pastorino (Oct 10 2019 at 13:42, on Zulip):

https://github.com/rust-lang/team/blob/master/teams/compiler.toml#L41-L55 compiler@rust-lang.org seems to be the same too

nikomatsakis (Oct 11 2019 at 13:14, on Zulip):

@centril to follow up on this, what I had in mind was:

@rustbot beta-nominate team...

as the syntax, and rustbot adds the appropriate T- labels. If there is already a T- label, maybe team... can be an empty list. Otherwise, you get back a (hopefully immediate!) error.

nikomatsakis (Oct 11 2019 at 13:15, on Zulip):

I would think a similar nominate system might be used to add I-nominated tags (and ensure there is a team)

nikomatsakis (Oct 11 2019 at 13:15, on Zulip):

This would be a good place for people to leave comments explaining why they nominated something, too :)

nikomatsakis (Oct 11 2019 at 13:16, on Zulip):

If we want to get fancy, we can edit the top-post with something like


Status: Nominated on 2019.10.11 for T-compiler, [see this comment for details].

simulacrum (Oct 11 2019 at 13:16, on Zulip):

editing the top post is not too hard since we already have logic implemented for that :)

centril (Oct 11 2019 at 13:27, on Zulip):

@nikomatsakis seems ok as a package :slight_smile:

nikomatsakis (Oct 11 2019 at 14:00, on Zulip):

I think a good goal would be that humans don't adjust labels manually

nikomatsakis (Oct 11 2019 at 14:00, on Zulip):

We can get there incrementally, of course

nikomatsakis (Oct 11 2019 at 14:00, on Zulip):

But if we can use a bot it gives us so much flexibility to enforce conventions, ping people, etc

nikomatsakis (Oct 11 2019 at 14:00, on Zulip):

Not to mention access rights

centril (Oct 11 2019 at 14:01, on Zulip):

@nikomatsakis the main issue is humans writing bot code ^^

centril (Oct 11 2019 at 14:01, on Zulip):

(it tends not to happen...)

simulacrum (Oct 11 2019 at 15:27, on Zulip):

I think it can and will happen more with targeted and clear specs

simulacrum (Oct 11 2019 at 15:27, on Zulip):

At least in my eyes that's the main problem historically

nikomatsakis (Oct 11 2019 at 15:44, on Zulip):

my impression is that rustbot is going strong

nikomatsakis (Oct 11 2019 at 15:44, on Zulip):

maybe I will try to hack on it and learn how it works

nikomatsakis (Oct 11 2019 at 15:44, on Zulip):

:P

nikomatsakis (Oct 11 2019 at 15:45, on Zulip):

(when niko writes a sentence that starts with 'maybe I', it's kind of like if false => P -- it's always true, but never relevant...)

nikomatsakis (Oct 11 2019 at 15:45, on Zulip):

"If I have time I will do X" is true for any X

nikomatsakis (Oct 11 2019 at 15:46, on Zulip):

the main issue is humans writing bot code ^^

butI kkind of don't get this :) it seems like a fun way to contribute to rust project

nikomatsakis (Oct 11 2019 at 15:46, on Zulip):

maybe we just need to blog more about rustbot etc

centril (Oct 11 2019 at 15:59, on Zulip):

@nikomatsakis yea, rustbot is also written in Rust so it should be more fun

centril (Oct 11 2019 at 15:59, on Zulip):

(unlike homu which is an uncommented pile of hacks)

Last update: Nov 20 2019 at 02:25UTC