Stream: t-compiler

Topic: template for future-compat lints


pnkfelix (Mar 08 2019 at 13:27, on Zulip):

hey @centril and @nikomatsakis , the template that niko linked ( https://forge.rust-lang.org/rustc-bug-fix-procedure.html ) during yesterday's discussion of PR #58608 diverges from the sample issue that @centril pointed at (#57742)

pnkfelix (Mar 08 2019 at 13:28, on Zulip):

which should I be using as the basis for new bugs? (If @centril 's represent the "correct" current template, then I will see about amending the RFC 1589 text...)

centril (Mar 08 2019 at 15:20, on Zulip):

@pnkfelix I wouldn't worry too much about the template; if in doubt, take the headings in both the example issue and the template and remove the duplication

centril (Mar 08 2019 at 15:20, on Zulip):

just be sure to label with C-future-compatibility

pnkfelix (Mar 08 2019 at 15:20, on Zulip):

I ended up adopting the format I saw in #58608

centril (Mar 08 2019 at 15:20, on Zulip):

alright :slight_smile:

pnkfelix (Mar 08 2019 at 15:21, on Zulip):

since I saw other C-future-compatibility issues using it

pnkfelix (Mar 08 2019 at 15:21, on Zulip):

and it is far more recent than the text of RFC 1589

centril (Mar 08 2019 at 15:21, on Zulip):

right; most future compat issues just copy from old ones

centril (Mar 08 2019 at 15:21, on Zulip):

that's likely why

pnkfelix (Mar 08 2019 at 15:21, on Zulip):

I still want to go back and try to amend the template that appears in the RFC 1589 text, in any case

centril (Mar 08 2019 at 15:22, on Zulip):

Sounds good :+1:

pnkfelix (Mar 08 2019 at 16:02, on Zulip):

Posted as rfcs amendment https://github.com/rust-lang/rfcs/pull/2658

nikomatsakis (Mar 08 2019 at 17:09, on Zulip):

Let a few comments

Last update: Nov 22 2019 at 06:00UTC