Stream: t-compiler

Topic: #58054 rustdoc ICE when importing non-macro attr


QuietMisdreavus (Feb 01 2019 at 15:00, on Zulip):

i just got a report of a rustdoc ICE with a crate that had use proc_macro_attribute in it. should this be allowed? >_>

QuietMisdreavus (Feb 01 2019 at 15:00, on Zulip):

i'll try to see about mitigating it in rustdoc, but i wonder if it should be reported in the compiler as well

nikomatsakis (Feb 01 2019 at 15:28, on Zulip):

I remember @Vadim Petrochenkov having some recent PR about this

nikomatsakis (Feb 01 2019 at 15:31, on Zulip):

can't find it now though

Vadim Petrochenkov (Feb 01 2019 at 15:39, on Zulip):

Allowed, see https://github.com/rust-lang/rust/issues/56417.

Vadim Petrochenkov (Feb 01 2019 at 15:40, on Zulip):

Otherwise we'd have collateral damage, e.g. use proc_macro would be an error because it's a built-in attribute in addition to the crate.

QuietMisdreavus (Feb 01 2019 at 15:41, on Zulip):

yeah, i saw the proc_macro example in the issue, hmm

QuietMisdreavus (Feb 01 2019 at 15:41, on Zulip):

thanks for the context, i'll see about making rustdoc ignore these imports

QuietMisdreavus (Feb 01 2019 at 15:42, on Zulip):

(waiting on an llvm build right now >_>)

Last update: Nov 22 2019 at 04:30UTC