Stream: t-compiler

Topic: Remove -Zprofile-queries?


mw (Oct 01 2019 at 15:01, on Zulip):

Does anyone use -Z profile-queries? It seems largely unused, possibly bit-rotted, and clutters some of the core query infrastructure.

mw (Oct 01 2019 at 15:01, on Zulip):

^ @nikomatsakis

simulacrum (Oct 01 2019 at 16:02, on Zulip):

I think we should feel free to strip out profiling unrelated to -Zself-profile

Zoxc (Oct 01 2019 at 23:43, on Zulip):

If -Zself-profile has the same functionality I think we can just remove it

Zoxc (Oct 01 2019 at 23:44, on Zulip):

I think I tried to use it once, but I wasn't successful =P

mw (Oct 02 2019 at 11:18, on Zulip):

If -Zself-profile has the same functionality I think we can just remove it

It could have the same functionality. -Zself-profile will soon be able to record all the data needed (it doesn't support query keys yet).

Wesley Wiser (Oct 02 2019 at 13:23, on Zulip):

I think if people aren't using it, then it's ok to remove it even if we're not up to 100% parity with -Zself-profile

nikomatsakis (Oct 03 2019 at 13:25, on Zulip):

Remove it imo

simulacrum (Oct 04 2019 at 01:29, on Zulip):

Going to file a PR removing it shortyl

mw (Oct 07 2019 at 09:16, on Zulip):

reviewing that PR is in my TODO list. Thanks @simulacrum !

Last update: Nov 21 2019 at 14:15UTC