Stream: t-compiler

Topic: miri should_panic rustdoc


simulacrum (Mar 03 2019 at 17:13, on Zulip):

@RalfJ I noticed that https://github.com/rust-lang/rust/pull/58689/ doesn't seem to add the ignore flag to rustdoc; would that be helpful for Miri? The infra team will need it to disable should_panic tests fully on android but if miri doesn't actually need it I might just stick an environment variable check inside rustdoc instead of properly threading it through

simulacrum (Mar 03 2019 at 17:44, on Zulip):

Turns out rustdoc isn't playing nice with should_panic anyway so I'll just avoid trying to fix it for the time being

RalfJ (Mar 03 2019 at 17:58, on Zulip):

miri and rustdoc aren't compatible anyway currently

simulacrum (Mar 03 2019 at 17:59, on Zulip):

okay, sounds good -- probably doesn't matter to you yet then :)

RalfJ (Mar 03 2019 at 17:59, on Zulip):

yeah I dont think it does

simulacrum (Mar 03 2019 at 17:59, on Zulip):

Then I definitely won't invest time in trying to finagle rustdoc into doing the right thing

Last update: Nov 16 2019 at 02:25UTC