I've noticed that
quote::parse has a bunch of unused params: macro_node_id, features, attrs. They are not mark as used, b/c the function is recursive. They were used previously to implement
? (which wasn't available on 2015), but are unused now.
Should we remove them, or should we keep them for future use? cc @Vadim Petrochenkov
macro_node_id is especially eyebrow raising one for me, as it seems like macro parsing should be independent of a particular node id?
macro_node_id is especially eyebrow raising
Perhaps it was used for lint reporting or something.
I'm pretty sure they can be removed, yeah.