Stream: t-compiler

Topic: unused parameters in `quote::parse`


matklad (Sep 23 2019 at 13:26, on Zulip):

I've noticed that quote::parse has a bunch of unused params: macro_node_id, features, attrs. They are not mark as used, b/c the function is recursive. They were used previously to implement ? (which wasn't available on 2015), but are unused now.

Should we remove them, or should we keep them for future use? cc @Vadim Petrochenkov

I the macro_node_id is especially eyebrow raising one for me, as it seems like macro parsing should be independent of a particular node id?

Vadim Petrochenkov (Sep 24 2019 at 17:17, on Zulip):

macro_node_id is especially eyebrow raising

Perhaps it was used for lint reporting or something.

Vadim Petrochenkov (Sep 24 2019 at 17:18, on Zulip):

I'm pretty sure they can be removed, yeah.

Last update: Nov 21 2019 at 13:45UTC