Stream: t-compiler

Topic: what should niko look at


nikomatsakis (May 01 2019 at 13:24, on Zulip):

@pnkfelix I'm taking some time to dig into things assigned to me at the moment. I am currently looking at

but I also have

pnkfelix (May 01 2019 at 14:05, on Zulip):

So it looks like @Matthew Jasper had a PR to outlaw returning closures holding lifetimes that were too long, and that included a “principled fix” to, I think, the impl Trait issue I mentioned to you

pnkfelix (May 01 2019 at 14:05, on Zulip):

This is PR #60332

pnkfelix (May 01 2019 at 14:06, on Zulip):

But a crater run led them to abandon the PR

pnkfelix (May 01 2019 at 14:06, on Zulip):

If you don’t get to it today, I’ll try to look at that crater run results tomorrow; id like to know if we should try teasing out the impl Trait change on its own, if possible

pnkfelix (May 01 2019 at 14:07, on Zulip):

(Possibly as a future-compat warning, to sidestep the crater run issues? Not sure.)

nikomatsakis (May 01 2019 at 14:29, on Zulip):

OK, I remember that I had a PR (nt sure of its current state) aiming at a similar thing

nikomatsakis (May 01 2019 at 14:31, on Zulip):

I am thinking of https://github.com/rust-lang/rust/pull/55988

nikomatsakis (May 01 2019 at 14:31, on Zulip):

it may or may not be related :)

Matthew Jasper (May 01 2019 at 14:34, on Zulip):

I wondered what happened to that when I was working on #60332. I'll have a look to see if it provides a viable approach for us.

nikomatsakis (May 01 2019 at 14:39, on Zulip):

For now i'm going to look some more into #60010

nikomatsakis (May 01 2019 at 14:39, on Zulip):

I got distracted by needing to rebuild

Alexey Shmalko (May 03 2019 at 19:44, on Zulip):

I have a small fix to Canonicalization chapter of rustc-guide that have been waiting for review for quite some time now (#304). It would be nice if you could take a look, as you have authored the chapter.

eddyb (May 03 2019 at 20:35, on Zulip):

In case you're running out of things :P

https://github.com/rust-lang/rust/pull/59288#discussion_r280920078

https://github.com/rust-lang/rust/pull/60525

eddyb (May 04 2019 at 01:14, on Zulip):

or if you have opinions on https://github.com/rust-lang/rust/pull/60530

eddyb (May 06 2019 at 13:55, on Zulip):

this one is not one of mine, but they are asking for you https://github.com/rust-lang/rust/pull/49799#issuecomment-489493241

Last update: Nov 22 2019 at 04:35UTC