In https://github.com/rust-lang/rust/pull/62848, I am trying to remove
char::is_xid_continue from libcore. The problem I face is that these two methods are the only one annotated with
feature = "rustc_private", so, If I remove them, rustc complains that it knows no such feature.
I think I need to make
rustc_private a language feature, as opposed to library features. I've tried to add it to
(active, rustc_private, "1.0.0", None, None),, but I still get "error[E0635]: unknown feature
What should I do? :)
@matklad I presume you'll want
#[cfg_attr(bootstrap, unstable(...))]since stage1+ will know about it via libsyntax but before then we won't
@simulacrum doesn't seem to help:
error[E0635]: unknown feature `rustc_private` --> src/libstd/lib.rs:309:32 | 309 | #![cfg_attr(bootstrap, feature(rustc_private))] | ^^^^^^^^^^^^^
I am also not sure if it should help. My understanding is that the main thing that
rustc_private unlocks is using compler-private crates. If I don't activate that feature, I'll get missing crates errors?
hm, is that during stage 1 or stage 0 compilation?
missing crates, no, but a bunch of feature gate warnings
it might be that we're not properly hooking into rustc-private via
that is, the new rustc_private