Stream: t-compiler

Topic: rustdoc help


Ariel Ben-Yehuda (Dec 15 2018 at 15:30, on Zulip):

Who knows rustdoc well?

QuietMisdreavus (Dec 15 2018 at 15:34, on Zulip):

@Ariel Ben-Yehuda i'm not going to be available until later this afternoon (US-Central) but :wave:

QuietMisdreavus (Dec 15 2018 at 15:35, on Zulip):

if your question has a short answer i may be able to help right now tho

Ariel Ben-Yehuda (Dec 15 2018 at 15:35, on Zulip):

k

Ariel Ben-Yehuda (Dec 15 2018 at 15:36, on Zulip):

what do you think about this hack-fix: https://github.com/rust-lang/rust/pull/56837#event-2028236790 (https://github.com/rust-lang/rust/pull/56837/commits/ac758531fa8dfee7e294e9c25e9096a3c4cc59a0)

QuietMisdreavus (Dec 15 2018 at 15:43, on Zulip):

hmm

QuietMisdreavus (Dec 15 2018 at 15:43, on Zulip):

i'm not sure i understand the representation of trait objects enough to know what's going on here

QuietMisdreavus (Dec 15 2018 at 15:53, on Zulip):

what is principal_def_id doing in this commit?

QuietMisdreavus (Dec 15 2018 at 15:53, on Zulip):

i guess i should read through the rest of the PR

QuietMisdreavus (Dec 15 2018 at 16:03, on Zulip):

i think this seems sound enough, looks like you're making something like Box<Send> possible, where it might have ICE'd (or been represented as Box<Send + Send> before

QuietMisdreavus (Dec 15 2018 at 16:04, on Zulip):

i need to head out now, but it doesn't seem outlandish upon this first reading

Ariel Ben-Yehuda (Dec 15 2018 at 16:07, on Zulip):

@QuietMisdreavus

I was trying to make Box<Send + Sync> be the same as Box<Sync + Send>

Ariel Ben-Yehuda (Dec 15 2018 at 16:08, on Zulip):

as [AutoTrait(Send), AutoTrait(Sync)]

Ariel Ben-Yehuda (Dec 15 2018 at 16:08, on Zulip):

as opposed to [Trait(Send), AutoTrait(Sync)] vs. [Trait(Sync), AutoTrait(Send)]

Last update: Nov 16 2019 at 01:05UTC