Stream: t-compiler

Topic: review guide pr


mark-i-m (May 14 2020 at 16:26, on Zulip):

Hi, could someone take a look at https://github.com/rust-lang/rustc-dev-guide/pull/697

mark-i-m (May 14 2020 at 16:27, on Zulip):

I think it is right, but I don't feel confident about it

nikomatsakis (May 14 2020 at 17:32, on Zulip):

@mark-i-m left some comments

nikomatsakis (May 14 2020 at 17:33, on Zulip):

I hadn't seen that before, sorry

nikomatsakis (May 14 2020 at 17:33, on Zulip):

currently teetering on my ability to keep up with GH notifications and reviews, partially underwater, but hoping not to drown =) :water_drop:

nikomatsakis (May 14 2020 at 17:34, on Zulip):

we should hook up the bot (whichever one it is) that makes r? work...

LeSeulArtichaut (May 14 2020 at 17:44, on Zulip):

nikomatsakis said:

we should hook up the bot (whichever one it is) that makes r? work...

(I think that is still @high-five since triagebot#433 didn't land yet)

Last update: Jun 04 2020 at 17:05UTC