Stream: t-compiler

Topic: perf.rlo broken - script-servo benchmarks


mw (Jan 06 2020 at 13:25, on Zulip):

https://perf.rust-lang.org/status.html shows script-servo compilation erroring with:

error: internal compiler error: mutable allocation in constant
    --> /tmp/.tmpL9Kzt5/target/debug/build/script-76da5cd8e8022d4a/out/Bindings/AttrBinding.rs:1013:64
     |
1013 |   const sAttributes_specs: &'static [&'static[JSPropertySpec]] = &[
     |  ________________________________________________________________^
1014 | | &[
1015 | |     JSPropertySpec {
1016 | |         name: b"namespaceURI\0" as *const u8 as *const libc::c_char,
...    |
1081 | |
1082 | | ];
     | |_^

@WG-const-eval does that look correct to you?

mw (Jan 06 2020 at 13:27, on Zulip):

@Simon Sapin, do you know someone who could help fix this? It looks like the current version of Servo also has this code and might be hit by the same issue soon.

mw (Jan 06 2020 at 13:30, on Zulip):

I just found this: https://github.com/rust-lang/rust/issues/67601

mw (Jan 06 2020 at 13:32, on Zulip):

and the PR that will hopefully fix the issue: https://github.com/rust-lang/rust/pull/67603

Simon Sapin (Jan 06 2020 at 14:27, on Zulip):

Yes, we’re also waiting on that PR to be able to upgrade the toolchain in Servo

simulacrum (Jan 06 2020 at 15:10, on Zulip):

I've elected not to change the code in perf.rlo given that we expect a bug fix to the compiler soon, and it looked non-obvious that a targeted fix existed.

mw (Jan 07 2020 at 09:59, on Zulip):

yes, just waiting for the fix seems sensible

mw (Jan 16 2020 at 16:01, on Zulip):

Fixed :crab:

Last update: May 26 2020 at 10:35UTC