Stream: t-compiler

Topic: pre-meeting triage 2020-02-06 #54818


pnkfelix (Feb 06 2020 at 12:16, on Zulip):

I will be doing pre-triage in this channel.

pnkfelix (Feb 06 2020 at 12:20, on Zulip):

There are 10 nominated unprioritized issues

pnkfelix (Feb 06 2020 at 12:21, on Zulip):

list of issues

pnkfelix (Feb 06 2020 at 12:21, on Zulip):

nom unpri 1/10: "miri no longer builds after rust-lang/rust#68861" #68878

pnkfelix (Feb 06 2020 at 12:21, on Zulip):

Tool failure. P-medium. Removing nomination tag.

pnkfelix (Feb 06 2020 at 12:22, on Zulip):

nom unpri 2/10: "1.40.0 ICE while reporting ICE" #68813

pnkfelix (Feb 06 2020 at 12:24, on Zulip):

needs investigation at least. Marking P-high for now, removing nomination.

pnkfelix (Feb 06 2020 at 12:24, on Zulip):

(This seems like it would be a good fit for the upcoming ICEBreakers-Cleanup crew)

pnkfelix (Feb 06 2020 at 12:28, on Zulip):

I added a cross reference so that people looking at the cleanup crew issue will hopefully see that this issue is a candidate.

pnkfelix (Feb 06 2020 at 12:30, on Zulip):

nom unpri 3/10: "TEXTREL in i686 since 1.41.0" #68794

pnkfelix (Feb 06 2020 at 12:31, on Zulip):

this is bad: its a stable-to-stable regression, and if I understand correctly, it breaks all android builds

pnkfelix (Feb 06 2020 at 12:31, on Zulip):

triage: P-high, leaving nominated to discuss at meeting. assigning to self.

pnkfelix (Feb 06 2020 at 12:37, on Zulip):

this is bad: its a stable-to-stable regression, and if I understand correctly, it breaks all android builds

correction: It might only break android-x86? Not sure yet.

pnkfelix (Feb 06 2020 at 12:38, on Zulip):

nom unpri 4/10: "Unable to compile syntex_syntax using Rust 1.41" #68729

pnkfelix (Feb 06 2020 at 12:39, on Zulip):

#68729 was expected fallout from PR #65785; see specifically this comment from @Vadim Petrochenkov ...

pnkfelix (Feb 06 2020 at 12:43, on Zulip):

I'm going to leave this nominated but triage it as P-low, with intent to close.

pnkfelix (Feb 06 2020 at 12:48, on Zulip):

nom unpri 5/10: "'index out of bounds: the len is 1 but the index is 1': libcore/slice/mod.rs" #68801

pnkfelix (Feb 06 2020 at 12:52, on Zulip):

two people have hit this, both provided stack traces, but neither provided any hint of source code to demo it.

pnkfelix (Feb 06 2020 at 12:54, on Zulip):

not sure what action we can take here. The two stack traces alone aren't enough, I think.

pnkfelix (Feb 06 2020 at 12:55, on Zulip):

I'll leave this unprioritized for now, but try to keep the dialogue going with the reporters.

pnkfelix (Feb 06 2020 at 13:09, on Zulip):

nom unpri 6/10: "ICE with const enum method returning Self" #68684

pnkfelix (Feb 06 2020 at 13:10, on Zulip):

looks like it has a trivial fix.

pnkfelix (Feb 06 2020 at 13:10, on Zulip):

#68684: assigning to self. P-high. Removing nomination label.

pnkfelix (Feb 06 2020 at 13:16, on Zulip):

nom unpri 7/10: "Compiler panic evaluating complex associated types" #68578

pnkfelix (Feb 06 2020 at 13:16, on Zulip):

closing as duplicate of #62529 (and I added #68578 to the growing list in the former bug's description)

pnkfelix (Feb 06 2020 at 13:18, on Zulip):

but I'm also going to nominate #62529 for discussion and add it to today's agenda.

pnkfelix (Feb 06 2020 at 13:24, on Zulip):

nom unpri 8/10: "Rustc bug:cannot convert ReEmpty to a region vid" #68550

pnkfelix (Feb 06 2020 at 13:25, on Zulip):

funny, I feel like we used to see this panic message all the time, but its been a while since I triaged one ...

pnkfelix (Feb 06 2020 at 13:28, on Zulip):

triage: P-high, assigning to self, removing nomination label.

pnkfelix (Feb 06 2020 at 13:29, on Zulip):

also, I think some of the bugs we covered so far could possibly benefit from use of #[track_caller] in libcore and/or compiler source. Maybe.

pnkfelix (Feb 06 2020 at 13:30, on Zulip):

nom unpri 9/10: "ICE: cannot convert ReEarlyBound(0, 'a) to a region vid" #68532

pnkfelix (Feb 06 2020 at 13:31, on Zulip):

triage: P-high, assiging to self, removing nomination label

pnkfelix (Feb 06 2020 at 13:32, on Zulip):

nom unpri 10/10: "[spurious] thread 'rustc' panicked at 'slice index starts at 24722962 but ends at 13279232', src/libcore/slice/mod.rs:2680:5" #68132

pnkfelix (Feb 06 2020 at 13:32, on Zulip):

I had meant for us to discuss this at the last meeting (two weeks ago) ...

pnkfelix (Feb 06 2020 at 13:38, on Zulip):

added #68132 to explicit nominated issues on agenda for today (there are 4 now; that is probably upper limit given how these things can go...)

pnkfelix (Feb 06 2020 at 13:40, on Zulip):

next: unprioritized beta-regressions; there are 4

pnkfelix (Feb 06 2020 at 13:40, on Zulip):

uh I mean 3

pnkfelix (Feb 06 2020 at 13:41, on Zulip):

beta-regr 1/3: "internal compiler error: unexpected lifetime bound" #68890

pnkfelix (Feb 06 2020 at 13:41, on Zulip):

seems like something with parser recovery, I'll bet

pnkfelix (Feb 06 2020 at 13:41, on Zulip):

could use bisection

pnkfelix (Feb 06 2020 at 13:42, on Zulip):

also, despite the fact that this is a beta-regression, I have a hard time assigning it high priority. You do get a useful diagnostic before the ICE, and it errors in all cases (stable, beta, nightly)

pnkfelix (Feb 06 2020 at 13:43, on Zulip):

triage #68890 : P-medium, removing nomination, adding needs-bisect.

pnkfelix (Feb 06 2020 at 13:45, on Zulip):

(also I think this is a case where cargo-bisect-rustc needs improvement, in terms of differentiated well-handled errors from ICE's. Which is filed as https://github.com/rust-lang/cargo-bisect-rustc/issues/34 . )

pnkfelix (Feb 06 2020 at 13:46, on Zulip):

beta-regr 2/3: "25% compile time increase on beta when building async-std" #68864

pnkfelix (Feb 06 2020 at 13:48, on Zulip):

25% compile time increase is troubling. Also, it might be good to see if we can extract a case to add to perf.rlo from this.

pnkfelix (Feb 06 2020 at 13:49, on Zulip):

triage: P-high, assigning to self.

pnkfelix (Feb 06 2020 at 13:49, on Zulip):

beta regr 3/3: "Worsened debug build codegen in beta" #68855

pnkfelix (Feb 06 2020 at 13:53, on Zulip):

not sure how to prioritize this. asked issue filer for more detail on what motivated their investigation.

pnkfelix (Feb 06 2020 at 13:53, on Zulip):

lets add this to the nominated list for discussion at today's triage meeting.

pnkfelix (Feb 06 2020 at 13:56, on Zulip):

next: unprioritized nightly regressions; there is one

pnkfelix (Feb 06 2020 at 13:56, on Zulip):

"cargo check --message-format json regression of error span data on empty main.rs file" #68808

pnkfelix (Feb 06 2020 at 13:57, on Zulip):

interestingly, this is affecting rust-analyzer

pnkfelix (Feb 06 2020 at 13:57, on Zulip):

triage: P-high. Assigning to self.

pnkfelix (Feb 06 2020 at 13:58, on Zulip):

(but I might delegate after some preliminary investigation.)

pnkfelix (Feb 06 2020 at 13:59, on Zulip):

okay next i want to make the list of backport nominations...

Last update: Feb 25 2020 at 04:05UTC