Stream: t-compiler

Topic: #65401 delay_span_bug not preserved by incremental


traxys (Oct 15 2019 at 16:14, on Zulip):

Just to be sure on what to do on this, I need to make the last snippet from here not ICE anymore, and the places mentionned in the issue are the places I should start by looking at ? ( rust/src/librustc_incremental/persist/fs.rs & rust/src/librustc_incremental/persist/save.rs)

traxys (Oct 15 2019 at 19:52, on Zulip):

So I changed the if sess.has_errors() to if sess.has_errors_or_delayed_span_bugs()in the fs.rs and returned early in the save.rs in the same case, and this gives the warning

warning: Error finalizing incremental compilation session directory `/home/traxys/rust/rust/ice_snip/foo-incr/snip-r3d3vtpzbif2/s-fgxkyk7had-1krhggp-working`: No such file or directory (os error 2)

I think it is because returning early is not what should be done. But now the compiler ICEs evrytime on the snippet, I believe this is what should happen ?

traxys (Oct 15 2019 at 20:05, on Zulip):

Okay so I guess it is wanted behavior seeing the end of the finalize function to warn when the session dir was deleted

Last update: Nov 20 2019 at 01:30UTC