Spawning off from weekly meeting.
It seems like the first proposed change to the inference propsed (only stripping the extension when it is
.exe) seems trivial enough. I'm not too familiar with what would be required to stablize
-C linker-flavour though.
-Clinker-flavour would involve making a patch and getting it go through a FCP
which is also quite easy (usually involves removing code, not adding it)
Is this guide up-to-date? https://forge.rust-lang.org/stabilization-guide.html
Alright, thanks, I should be good to get started on this.
Ah, also @davidtwco you’ll want to keep the two PRs (one that only strips the
exe extension and the stabilisation one) separate
Yeah, I figured that'd be the case :thumbs_up:
@nagisa are there tests for the linker stuff anywhere?
There should be at least a test for the -Z flag.
There does not appear to be a test for
-Clinker operation though
I can't find any for the linked flavor inference - PR that added it doesn't have any.
and it is super platform-specific anyway…
I’m not sure how you'd even check what linker rustc picks with given flags…
Fair enough, I guess I'll just open a PR with what I've got then.
It's really difficult to not spell flavour with the 'u'.
I’ve just given up on not spelling the non-american english way
I've just given up on
notspelling the non-american english way
the double-negative was intended :slight_smile: I just spell the british way instead.
Ah, I wasn't sure if I was parsing that wrong or not.
@nagisa submitted #56349 with the first change
@nagisa submitted #56351 with the stabilization.
-Clinker-flavour stabilized, can we now default to LLD on major platforms?
@mw I see no problem changing to lld by default even without stabilising that
as -Clinker will infer the correct linker flavour
Did the British English version get stabilized? I thought that the compiler options were American English.
The option was always in American English IIRC. Only place I ever used British English was in commit messages (before I caught myself and changed it).
Yes, we use AmE everywhere in the compiler. That may change once we get localisation of the diagnostics and error code descriptions
but till then…
I was just seeing :
That’s just me being silly and typing too fast to correct myself later
And mw as well ;-)