Hey! There are a lot of beta nominations for T-compiler, could you check them out?
@Pietro Albini We typically go through the beta-nominations at our weekly meeting. Last week's got a bit bogged down, so we didn't properly go through the list at that time, and then clearly the list has also grown since then...
so the question becomes: Do we try to apply some sort of asynchronous and/or ad-hoc system for approving backports in the meantime, or do we wait until the meeting coming this Thursday
I know that @nikomatsakis often will approve things for beta-backporting that are "obviously fine" based on his personal evaluation. Its possible that I (or he, or another member of @T-compiler ) should go through that process today or tomorrow, just to reduce the size of the list going into the meeting on thursday...
I tried that earlier. I wasn't very sure about my judgements so I left almost all of them alone. I can do another round and be more "aggressive"
I personally would like to try to ensure that members of the compiler team at least get a chance to object
So what i'm currently thinking is this: Its two days until the meeting anyway. We could have a policy that any member of the compiler team can write a comment stating that they think a beta-nominated PR should be backported
and then once we get to the meeting, that is the synchronization point
But instead of slowing waiting on each issue to see if anyone objects
we instead quickly enumerate the ones that have already been conditionally approved
at least, that sounds quicker to me than what I had been doing...
One might argue that the act of applying a beta-nomination tag should already count as the upvote for a backport
(and that I have simply been too slow in going through them.)
ups, well. I did those that I felt confident about (in necessity, backportability, code and the fact that the nomination wasn't mine)
Its fine, I'm more just trying to figure out what sort of long term precedent to set.
if a person is confident that a given PR is fine for backport, then it does seem wasteful to force it to wait until the team meeting.
@Oli I just want to confirm: when you removed the
beta-nominated tag from PR's like #54650, is there a corresponding merge to beta for that backport?
@Oli i.e. I believe our protocol is that we leave PR's tagged as both
beta-accepted when they are in the state that the given PR has been both "approved for backport" and that particular backport hasn't happened yet; we remove the
beta-nominated tag after the backport happens.
... given that the last commit to beta was 2 days ago, I am inferring that @Oli was not aware of the aforementioned protocol ...
(okay, I think I fixed all the cases of the problem in the previous comment now...)
beta-nominated should be removed when the backport is r+ed
I'll do a backport PR now
okay, either way, there were not yet backport PR's in this case, right?
Yea, I wasn't aware of that protocol. Thanks for the update
did a rollup PR for the backports :)
Ah zulip was eating notifications. Fixed now