Stream: t-compiler

Topic: ICE failed to lookup `SourceFile` in new context #70924


pnkfelix (May 30 2020 at 03:27, on Zulip):

hey @eddyb and @simulacrum , I finally put up that PR that I promised, over on "Track devirtualized filename"s #72767

pnkfelix (May 30 2020 at 03:28, on Zulip):

Its probably not the best long-term fix; at least, I know @eddyb was ... well, I don't know if "laughably unhappy" is the right term, but it did seem like they were both laughing and unhappy when they saw the problem

pnkfelix (May 30 2020 at 03:29, on Zulip):

but anyway, even though it may not be the best long term fix, it is one that I would be okay backporting to beta

pnkfelix (May 30 2020 at 03:29, on Zulip):

(which was to be done before, when @simulacrum ? before Monday?)

simulacrum (May 30 2020 at 03:32, on Zulip):

I think so, yeah

simulacrum (May 30 2020 at 03:33, on Zulip):

Well, we'll include it in the beta to stable promotion probably instead of separately landing it

simulacrum (May 30 2020 at 03:33, on Zulip):

If you tag it as accepted that'd be great

simulacrum (May 30 2020 at 03:35, on Zulip):

I'm guessing long term we should maybe just store the raw text of the files in metadata? I can't imagine it being a huge size increase or anything, especially if we run compression of some kind... Not entirely sure why we don't do that today.

pnkfelix (May 30 2020 at 03:39, on Zulip):

well we still want paths too, no?

pnkfelix (May 30 2020 at 03:39, on Zulip):

for local development

pnkfelix (May 30 2020 at 03:39, on Zulip):

I guess it depends on what metadata you're talking about

pnkfelix (May 30 2020 at 03:40, on Zulip):

I know I have been curious about storing raw text in our incremental build artifacts, but that is more because I would like to just spit out, as part of an incremental ICE: "here is the diff from the build we were using when we made the current set of artifacts"

pnkfelix (May 30 2020 at 03:43, on Zulip):

Also, I don't have a regression test as part of the PR, because I'm not sure how to make one

pnkfelix (May 30 2020 at 03:45, on Zulip):

my local replication relies on either adding/removing the rust-src component in rustup , or actually renaming the rustlib/src/rust subdirectory in my build directory. Either of these options don't seem to lend themselves to a test in our infrastructure, no?

pnkfelix (May 30 2020 at 03:45, on Zulip):

(I will transcribe the last two comments to the github PR, because it seems like a generally useful comment. and maybe someone will have a bright idea about how to test this scenario.)

pnkfelix (May 30 2020 at 03:47, on Zulip):

@simulacrum If I tag it as beta accepted, will you still wait for someone (hopefully @eddyb ) to r+ it before you put it into the beta-to-stable promotion?

simulacrum (May 30 2020 at 03:47, on Zulip):

Yeah, sure

simulacrum (May 30 2020 at 03:47, on Zulip):

(leave a comment please to that effect)

pnkfelix (May 30 2020 at 03:47, on Zulip):

(I don't want to inadvertantly bypass the review process just because I'm willing to take the heat for a unilateral beta approval)

pnkfelix (May 30 2020 at 03:47, on Zulip):

Okay I will do so

simulacrum (May 30 2020 at 03:49, on Zulip):

A run-make test could mess with the sysroot (or a copy of it) I guess, but it would probably be fairly error prone

pnkfelix (May 30 2020 at 03:49, on Zulip):

hmm

simulacrum (May 30 2020 at 03:50, on Zulip):

Also quite slow I imagine, especially on Windows? Not sure.. generally I don't think we have a good story for incremental tests

simulacrum (May 30 2020 at 03:50, on Zulip):

I at least always struggle to read them quickly

pnkfelix (May 30 2020 at 03:50, on Zulip):

I mean we do have a nice infrastructure with the revision system

pnkfelix (May 30 2020 at 03:51, on Zulip):

depending on your point of view

pnkfelix (May 30 2020 at 03:51, on Zulip):

it at least makes authoring certain cases easy

pnkfelix (May 30 2020 at 03:51, on Zulip):

but i'll admit that may not be so great for people trying to understand them

simulacrum (May 30 2020 at 03:51, on Zulip):

Yes, I usually need to spend a bit of time refreshing myself on what is going on before I can interpret revision tests

simulacrum (May 30 2020 at 03:52, on Zulip):

Maybe that's unavoidable :)

Last update: Jul 03 2020 at 17:45UTC