#71205 is currently assigned to eddyb but I think they have other things to do and other PRs to review. I expect #71205 to be pretty quick to review, and it would unblock my progress on #69274. There is nothing urgent, but it would be nice if someone had some time to review!
Code looks good to me. What kind of code is rejected by this that wasn't before? Only code using
#[target_feature], or other code as well?
I think that it concerns attributes that might be rejected
Take a look at the
For certain attributes, there are additional checks, and errors emitted
The only concern I see is that this might cause currently accepted code (on stable) to be rejected, for example malformed
Probably not worth starting a crater run just for this, but it's something to keep in mind
Code that might break with this PR is code that should be invalid though
If it breaks too much code we can also introduce a warning lint to have some transition
Yes, but often we've introduced these kinds of breaking changes by starting with a warning period. This doesn't really seem to be worth it in this case though, since the code is trivial to fix (remove the invalid attribute, or fix its syntax).
Yeah, seems fine. I've approved it.
Crater is running for the beta, if we want to run crater we’ll have to wait quite long :slight_smile:
Thanks @Jonas Schievink!