src/test/ui/borrowck/borrowck-feature-nll-overrides-migrate.rs test has a few revision-like comments, but there is a mistake: its compile-flags and edition are not taken into account because revision like attributes/flags cannot have a space between
[. cc @pnkfelix
we still have some ways to go towards making the unit test system robust :/
I'd like to see the
//~ ERROR lines mandatory, too
I think there was general agreement that we should just do that, i.e. make the lines mandatory (for
//~ ERROR, at least. I cannot remember what was decided about
//~ WARN). It might also be good to have
compiletest error on potential typos using a regexp like
//[ ]+\[.+\]~ or something
state of the system is that if you use one
//~ ERROR, you also need to annotate all warnings. I did not change that. I only changed that if you use zero annotations, you need to annotate errors and warnings
... so, wait, how is that different from making
//~ ERROR always mandatory?
I guess if there is a
//~ WARN annotation, then the
//~ ERROR ones are not mandatory...?
no, warn and error is always mandatory now
oh okay great
can you point me to PR and/or issue number?