Stream: t-compiler

Topic: borrowck-feature-nll-overrides-migrate test is wrong?


nagisa (Nov 25 2018 at 18:08, on Zulip):

src/test/ui/borrowck/borrowck-feature-nll-overrides-migrate.rs test has a few revision-like comments, but there is a mistake: its compile-flags and edition are not taken into account because revision like attributes/flags cannot have a space between // and [. cc @pnkfelix

nikomatsakis (Nov 26 2018 at 15:42, on Zulip):

we still have some ways to go towards making the unit test system robust :/

nikomatsakis (Nov 26 2018 at 15:42, on Zulip):

I'd like to see the //~ ERROR lines mandatory, too

pnkfelix (Nov 27 2018 at 12:04, on Zulip):

I think there was general agreement that we should just do that, i.e. make the lines mandatory (for //~ ERROR, at least. I cannot remember what was decided about //~ WARN). It might also be good to have compiletest error on potential typos using a regexp like //[ ]+\[.+\]~ or something

oli (Nov 27 2018 at 12:06, on Zulip):

state of the system is that if you use one //~ ERROR, you also need to annotate all warnings. I did not change that. I only changed that if you use zero annotations, you need to annotate errors and warnings

pnkfelix (Nov 27 2018 at 12:07, on Zulip):

... so, wait, how is that different from making //~ ERROR always mandatory?

pnkfelix (Nov 27 2018 at 12:07, on Zulip):

I guess if there is a //~ WARN annotation, then the //~ ERROR ones are not mandatory...?

oli (Nov 27 2018 at 12:07, on Zulip):

no, warn and error is always mandatory now

oli (Nov 27 2018 at 12:07, on Zulip):

no distinction

pnkfelix (Nov 27 2018 at 12:07, on Zulip):

oh okay great

pnkfelix (Nov 27 2018 at 12:07, on Zulip):

can you point me to PR and/or issue number?

oli (Nov 27 2018 at 12:08, on Zulip):

https://github.com/rust-lang/rust/pull/56244

pnkfelix (Nov 27 2018 at 12:08, on Zulip):

thx

Last update: Nov 22 2019 at 04:40UTC