Stream: t-compiler

Topic: pre-meeting triage 2020-01-02 #54818


pnkfelix (Jan 02 2020 at 13:29, on Zulip):

I will be doing pre-triage in this channel.

pnkfelix (Jan 02 2020 at 13:34, on Zulip):

happy new year @centril

pnkfelix (Jan 02 2020 at 13:35, on Zulip):

thank goodness, we only (?) have 13 nominated unpriroiritzed issues

pnkfelix (Jan 02 2020 at 13:35, on Zulip):

nom unpri 1/13: "miri no longer builds after rust-lang/rust#67676" #67793

centril (Jan 02 2020 at 13:35, on Zulip):

Happy new year @pnkfelix

pnkfelix (Jan 02 2020 at 13:36, on Zulip):

looks like it has a fix; just waiting for submodule to be updated. Anyway, I think #67793 is P-medium.

centril (Jan 02 2020 at 13:37, on Zulip):

do you have the link handy for the list of issues?

pnkfelix (Jan 02 2020 at 13:37, on Zulip):

nom unpri 2/13: "
Internal compiler error: building dynamic library is unsupported on Emscripten" #67782

pnkfelix (Jan 02 2020 at 13:37, on Zulip):

oh sure

pnkfelix (Jan 02 2020 at 13:37, on Zulip):

I'll back paste it.

pnkfelix (Jan 02 2020 at 13:38, on Zulip):

(Also, Its I think the first link from "Pre-triage Process" in #54818 )

centril (Jan 02 2020 at 13:38, on Zulip):

emscripten isn't a high prio target I think

pnkfelix (Jan 02 2020 at 13:38, on Zulip):

speaking of which, I probably should port that (the weekly meeting protocol) to the compiler-team website proper. Probsably.

pnkfelix (Jan 02 2020 at 13:39, on Zulip):

or maybe forge?

pnkfelix (Jan 02 2020 at 13:39, on Zulip):

/me looks briefly at https://github.com/rust-lang/compiler-team/issues/204

centril (Jan 02 2020 at 13:40, on Zulip):

it's probably a good idea to paste whatever the link is each meeting; I wouldn't remember where it was anyways :P

pnkfelix (Jan 02 2020 at 13:41, on Zulip):

oh the link is in the topic

pnkfelix (Jan 02 2020 at 13:41, on Zulip):

I had always thought that was obvious

centril (Jan 02 2020 at 13:42, on Zulip):

heh :D

pnkfelix (Jan 02 2020 at 13:42, on Zulip):

but I can understand that its not

pnkfelix (Jan 02 2020 at 13:42, on Zulip):

indeed, the ability to succinctly put the link in the topic is basically the only motivation for why the agenda lives there.

pnkfelix (Jan 02 2020 at 13:42, on Zulip):

but I digress. Heavily≥

pnkfelix (Jan 02 2020 at 13:42, on Zulip):

back to prioritization of #67782

centril (Jan 02 2020 at 13:43, on Zulip):

p-medium?

pnkfelix (Jan 02 2020 at 13:43, on Zulip):

yeah I think so

centril (Jan 02 2020 at 13:43, on Zulip):

possibly p-low

pnkfelix (Jan 02 2020 at 13:43, on Zulip):

possibly

pnkfelix (Jan 02 2020 at 13:44, on Zulip):

feels kind of yucky to prioritize any ICE as P-low, though

centril (Jan 02 2020 at 13:44, on Zulip):

true

pnkfelix (Jan 02 2020 at 13:44, on Zulip):

it depends on what aspect of the bug is under discussion

pnkfelix (Jan 02 2020 at 13:44, on Zulip):

anyway I'll call it P-med for now

centril (Jan 02 2020 at 13:45, on Zulip):

https://github.com/rust-lang/rust/issues/67778 <-- p-high?

pnkfelix (Jan 02 2020 at 13:46, on Zulip):

as in

pnkfelix (Jan 02 2020 at 13:46, on Zulip):

nom unpri 3/13 "async fn ICEs in macro on stable" #67778

pnkfelix (Jan 02 2020 at 13:46, on Zulip):

and yeah

pnkfelix (Jan 02 2020 at 13:47, on Zulip):

do I leave it nominated though

pnkfelix (Jan 02 2020 at 13:47, on Zulip):

I think I won't.

centril (Jan 02 2020 at 13:47, on Zulip):

I managed to cc petrochenkov again

pnkfelix (Jan 02 2020 at 13:48, on Zulip):

(I was thinking "clones" but I suppose that emoji doesn't necessarily mean that...)

centril (Jan 02 2020 at 13:49, on Zulip):

nom unpri 4/13 "Nightly 2019-12-29 causes reached the type-length limit error in previously working code " #67757

pnkfelix (Jan 02 2020 at 13:49, on Zulip):

nipe yip

centril (Jan 02 2020 at 13:49, on Zulip):

not really a bug, but also ungreat

centril (Jan 02 2020 at 13:50, on Zulip):

(and related to a perf regression on the side)

pnkfelix (Jan 02 2020 at 13:50, on Zulip):

wasn't #65244 going to be reverted ... ?

pnkfelix (Jan 02 2020 at 13:50, on Zulip):

or am I thiiniking of something else

centril (Jan 02 2020 at 13:50, on Zulip):

we bisected a big perf regression to that PR

centril (Jan 02 2020 at 13:50, on Zulip):

by perfbotting a revert PR

pnkfelix (Jan 02 2020 at 13:51, on Zulip):

yeah @Wesley Wiser was looking into whether reverting it resolved the perf issue

centril (Jan 02 2020 at 13:51, on Zulip):

but we haven't decided to revert

pnkfelix (Jan 02 2020 at 13:51, on Zulip):

in #67768

centril (Jan 02 2020 at 13:51, on Zulip):

yep

pnkfelix (Jan 02 2020 at 13:51, on Zulip):

but okay

pnkfelix (Jan 02 2020 at 13:51, on Zulip):

where was the decision made?

centril (Jan 02 2020 at 13:51, on Zulip):

to land the PR or to unland the PR?

pnkfelix (Jan 02 2020 at 13:51, on Zulip):

(just so I can link to it from the relevant points)

pnkfelix (Jan 02 2020 at 13:52, on Zulip):

oh I misunderstood

pnkfelix (Jan 02 2020 at 13:52, on Zulip):

or rather I misread

pnkfelix (Jan 02 2020 at 13:52, on Zulip):

thought you said "we decided not to revert". . . swapped words around

centril (Jan 02 2020 at 13:52, on Zulip):

;)

Since the IntoFuture PR caused two distinct forms of regressions it seems wise to discuss landing a revert in the full mtg

pnkfelix (Jan 02 2020 at 13:53, on Zulip):

yeah

pnkfelix (Jan 02 2020 at 13:53, on Zulip):

#67706 is nominated

centril (Jan 02 2020 at 13:53, on Zulip):

(Although T-lang and T-libs FCPed it, but I think we did not intend for these regressions...)

pnkfelix (Jan 02 2020 at 13:53, on Zulip):

let me create a hackmd.io page for today's meeting

pnkfelix (Jan 02 2020 at 13:53, on Zulip):

so I can make sure we cover this in nominations

centril (Jan 02 2020 at 13:53, on Zulip):

Speaking of... do we have t-lang mtg today? (or is it on the 6th?)

pnkfelix (Jan 02 2020 at 13:54, on Zulip):

Oh!

pnkfelix (Jan 02 2020 at 13:54, on Zulip):

that would be exciting

pnkfelix (Jan 02 2020 at 13:55, on Zulip):

I had forgotten we were going to change things up there

centril (Jan 02 2020 at 13:55, on Zulip):

we're having an extra meeting; thursdays are still on

pnkfelix (Jan 02 2020 at 13:55, on Zulip):

lets ask somewhere in #t-lang

centril (Jan 02 2020 at 13:55, on Zulip):

yep

pnkfelix (Jan 02 2020 at 13:55, on Zulip):

ah right

pnkfelix (Jan 02 2020 at 13:59, on Zulip):

nom unpri 5/13: "test/run-make-fulldeps/pgo-branch-weights fails occasionally on CI" #67746

centril (Jan 02 2020 at 13:59, on Zulip):

seems @mw is on it

centril (Jan 02 2020 at 13:59, on Zulip):

let's say p-high cause CI problems

pnkfelix (Jan 02 2020 at 13:59, on Zulip):

yeah. Intermittent CI failures I do indeed consider P-high

pnkfelix (Jan 02 2020 at 13:59, on Zulip):

especially if it can be addressed in short term by just disabling a test

pnkfelix (Jan 02 2020 at 14:00, on Zulip):

(and really, the form of the soluition should not affect the prirority, at least not until one has shown that a solution is truly monstrous relative to the severity of the problem.)

centril (Jan 02 2020 at 14:00, on Zulip):

nom unpri 6/13 -- Recent nightly doesn't support array length from indirectly referenced trait constant #67743

pnkfelix (Jan 02 2020 at 14:01, on Zulip):

(also removed nomination label from #67746)

pnkfelix (Jan 02 2020 at 14:02, on Zulip):

#67743 sounds P-high to me

centril (Jan 02 2020 at 14:02, on Zulip):

lazy normalization issue?

centril (Jan 02 2020 at 14:02, on Zulip):

cc @eddyb

pnkfelix (Jan 02 2020 at 14:02, on Zulip):

#67743: triage P-high, removing nomination

pnkfelix (Jan 02 2020 at 14:03, on Zulip):

nom unpri 7/13: "rls no longer builds after rust-lang/rust#67661" #67708

pnkfelix (Jan 02 2020 at 14:03, on Zulip):

triage P-medium removing nomination.

pnkfelix (Jan 02 2020 at 14:04, on Zulip):

nom unpri 8/13: "Major async/await compiler performance regression" #67706

pnkfelix (Jan 02 2020 at 14:04, on Zulip):

we already discussed this briefly

centril (Jan 02 2020 at 14:04, on Zulip):

p-high then

pnkfelix (Jan 02 2020 at 14:04, on Zulip):

triage: P-high, leaving nomination label.

centril (Jan 02 2020 at 14:04, on Zulip):

nom unpri 9/13 "internal compiler error: src/librustc_traits/normalize_erasing_regions.rs:42 #67684

pnkfelix (Jan 02 2020 at 14:05, on Zulip):

jesus

centril (Jan 02 2020 at 14:06, on Zulip):

let's ignore the off-topic remark in the issue...

centril (Jan 02 2020 at 14:06, on Zulip):

maybe @Matthew Jasper would be suitable

centril (Jan 02 2020 at 14:07, on Zulip):

though we don't even have a backtrace

pnkfelix (Jan 02 2020 at 14:07, on Zulip):

well, anyone should indeed be able to try to reproduce locally

pnkfelix (Jan 02 2020 at 14:07, on Zulip):

to make more progress, even in terms of getting a backtrace, as you note

centril (Jan 02 2020 at 14:07, on Zulip):

oh, yeah, right, forgot

pnkfelix (Jan 02 2020 at 14:07, on Zulip):

the filer does not seem terribly interested in collaborating in such a fashion

pnkfelix (Jan 02 2020 at 14:08, on Zulip):

anyway

pnkfelix (Jan 02 2020 at 14:08, on Zulip):

lets call it P-high for at least learning more about the bug itself

centril (Jan 02 2020 at 14:09, on Zulip):

yep

pnkfelix (Jan 02 2020 at 14:09, on Zulip):

but removing nomination

pnkfelix (Jan 02 2020 at 14:10, on Zulip):

nom unpri 10/13: "rustdoc does not verify feature gates" #67647

pnkfelix (Jan 02 2020 at 14:10, on Zulip):

do .... do we care ?

centril (Jan 02 2020 at 14:10, on Zulip):

wrong team?

pnkfelix (Jan 02 2020 at 14:10, on Zulip):

I guess its up to rustdoc team to decide priority

pnkfelix (Jan 02 2020 at 14:10, on Zulip):

yeah

centril (Jan 02 2020 at 14:10, on Zulip):

guess they don't really have triage

centril (Jan 02 2020 at 14:11, on Zulip):

nom unpri 11/13 " illegal instruction on x86_64-linux-android since 1.40.0 " #67582

pnkfelix (Jan 02 2020 at 14:12, on Zulip):

oy vey

pnkfelix (Jan 02 2020 at 14:12, on Zulip):

quite a stack of systems

pnkfelix (Jan 02 2020 at 14:13, on Zulip):

i cannot even tell, is it qemu that's hitting the illegal instruction there?

centril (Jan 02 2020 at 14:13, on Zulip):

x86 android seems exotic :P

pnkfelix (Jan 02 2020 at 14:13, on Zulip):

maybe it JIT's to native code or something.

pnkfelix (Jan 02 2020 at 14:14, on Zulip):

not sure what tier this target is

pnkfelix (Jan 02 2020 at 14:14, on Zulip):

@Pietro Albini @simulacrum is x86 android Tier-2 ?

pnkfelix (Jan 02 2020 at 14:14, on Zulip):

lets call #67582 P-medium for now.

centril (Jan 02 2020 at 14:14, on Zulip):

tier 2

centril (Jan 02 2020 at 14:14, on Zulip):

https://rust-lang.github.io/rustup-components-history/x86_64-linux-android.html

Pietro Albini (Jan 02 2020 at 14:14, on Zulip):

x86 or x86_64?

pnkfelix (Jan 02 2020 at 14:15, on Zulip):

triage: P-medium based on this being a tier-2 platform. Removing nomination.

pnkfelix (Jan 02 2020 at 14:15, on Zulip):

x86_64

pnkfelix (Jan 02 2020 at 14:16, on Zulip):

nom unpri 12/13: "ICE on invalid syntax in proc macro attr" #67567

centril (Jan 02 2020 at 14:16, on Zulip):

@pnkfelix maybe it would be useful to have ICE messages tell people to run a command that de-macro-ifies

pnkfelix (Jan 02 2020 at 14:16, on Zulip):

hmm, I was assuming a macro was necessary for repro here

pnkfelix (Jan 02 2020 at 14:17, on Zulip):

the DistinctSources part made me think that, at least.

centril (Jan 02 2020 at 14:17, on Zulip):

oh it's some span issue?

centril (Jan 02 2020 at 14:18, on Zulip):

sounds like @Esteban Küber should take a look when they are back ^^

pnkfelix (Jan 02 2020 at 14:18, on Zulip):

I guess the separate mod file must be part of it too, though.

pnkfelix (Jan 02 2020 at 14:18, on Zulip):

anyway

pnkfelix (Jan 02 2020 at 14:18, on Zulip):

you do currently get useful diagnostics

pnkfelix (Jan 02 2020 at 14:19, on Zulip):

so I'm inclined to call this P-medium

centril (Jan 02 2020 at 14:19, on Zulip):

sure

centril (Jan 02 2020 at 14:19, on Zulip):

nom unpri 13/13 "[ICE] with recursive impl trait and Iterator.by_ref()" #67552

pnkfelix (Jan 02 2020 at 14:20, on Zulip):

and that's an example of an ICE without a useful diagnostic.

pnkfelix (Jan 02 2020 at 14:21, on Zulip):

triage: P-high. Don't think there's anything worth discussing at meeting about it though, so removing nomination

pnkfelix (Jan 02 2020 at 14:22, on Zulip):

okay, next up, unprioritized beta regressions

pnkfelix (Jan 02 2020 at 14:22, on Zulip):

there are 2

pnkfelix (Jan 02 2020 at 14:23, on Zulip):

unpri beta regr 1/2: "failed to evaluate constant" #67612

pnkfelix (Jan 02 2020 at 14:23, on Zulip):

triage: P-high

pnkfelix (Jan 02 2020 at 14:23, on Zulip):

assigning to @oli

pnkfelix (Jan 02 2020 at 14:24, on Zulip):

unpri beta regr 2/2: "not Send due to await retainment" #67611

pnkfelix (Jan 02 2020 at 14:25, on Zulip):

I guess this is P-high too. I'll nominate it

centril (Jan 02 2020 at 14:25, on Zulip):

cc @davidtwco

pnkfelix (Jan 02 2020 at 14:29, on Zulip):

next, unprioritized nightly regressions

pnkfelix (Jan 02 2020 at 14:30, on Zulip):

unpri nightly regr 1/1: "Fn traits with array args no longer work with const_generics enabled" #67753

centril (Jan 02 2020 at 14:31, on Zulip):

p-medium or low I think

pnkfelix (Jan 02 2020 at 14:31, on Zulip):

commenters claim this is expected fallout of #66883.

centril (Jan 02 2020 at 14:31, on Zulip):

it's not an issue yet

pnkfelix (Jan 02 2020 at 14:31, on Zulip):

yet?

centril (Jan 02 2020 at 14:32, on Zulip):

on stable

pnkfelix (Jan 02 2020 at 14:32, on Zulip):

you mean because this is a known buggy feature anyway ?

pnkfelix (Jan 02 2020 at 14:32, on Zulip):

oh sure

centril (Jan 02 2020 at 14:32, on Zulip):

also known buggy...

pnkfelix (Jan 02 2020 at 14:32, on Zulip):

yeah okay

pnkfelix (Jan 02 2020 at 14:32, on Zulip):

I'll call it P-medium and move on

pnkfelix (Jan 02 2020 at 14:34, on Zulip):

next: prepass over nominations

pnkfelix (Jan 02 2020 at 14:36, on Zulip):

we did discuss #47048 two weeks ago

pnkfelix (Jan 02 2020 at 14:36, on Zulip):

yeah we basically "decided" then to ask @mati865 to move forward with experimentation here.

mati865 (Jan 02 2020 at 14:37, on Zulip):

https://github.com/rust-lang/rust/pull/67429 waits for the review

pnkfelix (Jan 02 2020 at 14:38, on Zulip):

yeah I'm going to remove nomination from #47048

pnkfelix (Jan 02 2020 at 14:39, on Zulip):

and also I'm going to assign the issue to @mati865

pnkfelix (Jan 02 2020 at 14:39, on Zulip):

I'll add PR #67429 to nominations for today

centril (Jan 02 2020 at 14:44, on Zulip):

made a reduction to https://github.com/rust-lang/rust/issues/67552#issuecomment-570227908 meanwhile :D

pnkfelix (Jan 02 2020 at 14:45, on Zulip):

okay, I've gone through the chat log from last meeting. There are no other issues in the currennt nominnation list that deserve to be un-nominated based on that log.

pnkfelix (Jan 02 2020 at 14:45, on Zulip):

lets make a formal list of the beta-nominations on the hackmd

pnkfelix (Jan 02 2020 at 14:58, on Zulip):

okay I've finished fleshing out the hackmd

pnkfelix (Jan 02 2020 at 14:58, on Zulip):

pretty proud of myself for even getting the backport emojis ready ahead of time.

Esteban Küber (Jan 02 2020 at 16:06, on Zulip):

@centril provisionally assigned the issue you mentioned me in for when I get back, but I don't know if we might have to escalate and have petrochenkov take a look at it too.

Last update: Jan 21 2020 at 08:25UTC