Stream: t-compiler

Topic: associated type bounds


Alexander Regueiro (Jan 07 2019 at 05:25, on Zulip):

So, I've modified lower_item_kind for ItemKind::Existential to allow ImplTraitContext::Existential for its bounds, but tests aren't going as expected. This has stumped me for a couple of days now. https://gist.github.com/alexreg/0163e1bc5d20af4619569ad281dbd661 -- could someone kindly take a look?

Alexander Regueiro (Jan 07 2019 at 05:25, on Zulip):

CC @nikomatsakis @varkor, but feel free to ignore if you're busy.

nikomatsakis (Jan 07 2019 at 15:51, on Zulip):

@Alexander Regueiro what's the context here? you're trying to make that example work?

Alexander Regueiro (Jan 07 2019 at 15:52, on Zulip):

@nikomatsakis yep.

Alexander Regueiro (Jan 07 2019 at 15:52, on Zulip):

Seems like it should be simple but....

Alexander Regueiro (Jan 07 2019 at 15:53, on Zulip):

The defining type doesn’t get found in the second case.

Alexander Regueiro (Jan 07 2019 at 15:53, on Zulip):

For the generated existential type

Alexander Regueiro (Jan 07 2019 at 16:59, on Zulip):

Any ideas @nikomatsakis?

nikomatsakis (Jan 07 2019 at 18:54, on Zulip):

sorry haven't had a chance to look yet, but tbh I can't make heads or tails of that gist

nikomatsakis (Jan 07 2019 at 18:54, on Zulip):

I guess it'd be easier if I had a branch to look at or something

nikomatsakis (Jan 07 2019 at 18:54, on Zulip):

the long lines are throwing me off :P

Alexander Regueiro (Jan 07 2019 at 21:34, on Zulip):

heh sorry

Alexander Regueiro (Jan 07 2019 at 21:34, on Zulip):

want me to push the WIP branch?

Alexander Regueiro (Jan 07 2019 at 21:37, on Zulip):

https://github.com/rust-lang/rust/pull/57428

Alexander Regueiro (Jan 07 2019 at 21:37, on Zulip):

@nikomatsakis

varkor (Jan 07 2019 at 22:20, on Zulip):

@Alexander Regueiro: it's really hard to read the diff when most of the changes are comment formatting changes

Alexander Regueiro (Jan 07 2019 at 22:21, on Zulip):

@varkor sorry, I should have separated those out... I usually do it at the end of a PR

varkor (Jan 07 2019 at 22:22, on Zulip):

it makes sense to make cosmetic changes in a different PR entirely, so the PR stands alone

Alexander Regueiro (Jan 07 2019 at 22:45, on Zulip):

@varkor there aren't that many cosmetic changes here. and anyway, I was probably going to add them to my other PR

Alexander Regueiro (Jan 07 2019 at 22:45, on Zulip):

Niko doesn't care much as long as it's a separate commit heh. so it depends who's reviewing I guess...

Alexander Regueiro (Jan 07 2019 at 22:45, on Zulip):

@varkor anyway, want me to rebase now, or have you figured it out?

Alexander Regueiro (Jan 08 2019 at 00:01, on Zulip):

@varkor well, let me know... I'm only going to rebase it it helps you debug. otherwise will wait until later

varkor (Jan 08 2019 at 21:07, on Zulip):

@Alexander Regueiro: if you rebase, I could have a look over to see if I spot anything

Last update: Nov 22 2019 at 04:30UTC