So, I've modified
ItemKind::Existential to allow
ImplTraitContext::Existential for its bounds, but tests aren't going as expected. This has stumped me for a couple of days now. https://gist.github.com/alexreg/0163e1bc5d20af4619569ad281dbd661 -- could someone kindly take a look?
CC @nikomatsakis @varkor, but feel free to ignore if you're busy.
@Alexander Regueiro what's the context here? you're trying to make that example work?
Seems like it should be simple but....
The defining type doesn’t get found in the second case.
For the generated existential type
Any ideas @nikomatsakis?
sorry haven't had a chance to look yet, but tbh I can't make heads or tails of that gist
I guess it'd be easier if I had a branch to look at or something
the long lines are throwing me off :P
want me to push the WIP branch?
@Alexander Regueiro: it's really hard to read the diff when most of the changes are comment formatting changes
@varkor sorry, I should have separated those out... I usually do it at the end of a PR
it makes sense to make cosmetic changes in a different PR entirely, so the PR stands alone
@varkor there aren't that many cosmetic changes here. and anyway, I was probably going to add them to my other PR
Niko doesn't care much as long as it's a separate commit heh. so it depends who's reviewing I guess...
@varkor anyway, want me to rebase now, or have you figured it out?
@varkor well, let me know... I'm only going to rebase it it helps you debug. otherwise will wait until later
@Alexander Regueiro: if you rebase, I could have a look over to see if I spot anything