Stream: t-compiler

Topic: review #58281

simulacrum (Nov 16 2019 at 22:35, on Zulip):

Not sure if anyone other than estebank is capable of reviewing, but it would be good to get some eyes on it and help @mark-i-m out, as it's been waiting for a while now.

@mark-i-m -- I wonder if we could try to land some parts of it rather than the whole thing? It would probably be also be helpful for reviewers if you could update the top-level description with a summary of the current implementation status and errata (I note that '_ handling in async/await is perhaps a not great 'patch' over the underlying problem, though it may be fine).

simulacrum (Nov 16 2019 at 22:36, on Zulip):

I also wonder if at this point it makes sense to close and reopen the PR just to minimize GH history (188 comments is a ton even if a lot of them are bot generated and such)

simulacrum (Nov 16 2019 at 22:37, on Zulip):

cc @pnkfelix @nikomatsakis as T-compiler leads

mark-i-m (Nov 17 2019 at 04:13, on Zulip):

Hi, thanks @simulacrum ! I updated the op with a description. Please let me know if I should add more detail

mark-i-m (Nov 17 2019 at 04:14, on Zulip):

Unfortunately I don't think it can be broken out more than it has already

mark-i-m (Nov 17 2019 at 04:14, on Zulip):

I can reopen if you want

simulacrum (Nov 17 2019 at 13:31, on Zulip):

I will try to take another look today

simulacrum (Nov 17 2019 at 23:36, on Zulip):

I am afraid I ran out of time today, hopefully will have time tomorrow though

nikomatsakis (Nov 19 2019 at 18:56, on Zulip):

ugh I think I failed to give feedback on that one, too, sorry @mark-i-m for my part in it

mark-i-m (Nov 20 2019 at 02:15, on Zulip):

No worries. It was a large PR

Last update: May 27 2020 at 22:55UTC