Can crater check warnings change?
I'd like to check how much noise https://github.com/rust-lang/rust/pull/55373 would cause in the ecosystem at large. Tried just keeping it as an error, but it breaks so many things (namely in this case,
crossbeam) that cargo doesn't even get to compile.
If we can monitor output change, not just breakage then I can change it from a hard error to a warning.
otherwise we're flying blind as to how much this change will break havoc
I don't think we can check warnings directly on crater
we can do a run with
Fair enough... That could work well enough...
but I will need to change the PR to be a lint
that might take me a while...
right now the check's done where it is easier, at the macro parsing stage
thanks @Pietro Albini, I'll go back to the drawing board and turn it into lint. It's probably what it should be regardless.
another option is to just execute a run with the new PR, download all the logs and analyze it locally
Do you have a link to the docs in order to do that?
I can very easily change the PR from err to warn, turning it into a lint would take me much longer
doing a quick grep on the results would give us actionable info the quickest
just start a normal run with the try toolchain
then, in the report there is the "downloads" section, with a tar.gz with all the logs
@Esteban Küber wait that PR confuses me a bit
It claims that "Macro pattern
($a:expr, $b:expr) is invalid, for good reason." but I think that is not true.
Perhaps you meant
@nikomatsakis yep, that's indeed what I meant :)