Stream: t-compiler

Topic: PR #61754


nikomatsakis (Jun 14 2019 at 11:18, on Zulip):

Hey @pnkfelix -- is this observation of a possible simplification worth stalling #61754 for?

nikomatsakis (Jun 14 2019 at 11:18, on Zulip):

I'm debating between that and doing a follow-up

pnkfelix (Jun 14 2019 at 11:27, on Zulip):

What?

pnkfelix (Jun 14 2019 at 11:28, on Zulip):

You mean stall it to switch to depth instead of the unique number in the traversal?

pnkfelix (Jun 14 2019 at 11:28, on Zulip):

I absolutely do not think it’s worth stalling for that

pnkfelix (Jun 14 2019 at 11:28, on Zulip):

Let’s get this sucker in the hands of the people!!

pnkfelix (Jun 14 2019 at 11:29, on Zulip):

Unless you think the simplified version would be more readily backported to beta ; but even then, I’d say do a follow up

pnkfelix (Jun 14 2019 at 11:29, on Zulip):

(And my guess is that the change would not be enough of a simplification to change minds about whether to backport or not)

nikomatsakis (Jun 14 2019 at 12:26, on Zulip):

Unless you think the simplified version would be more readily backported to beta ; but even then, I’d say do a follow up

no it's a small change

nikomatsakis (Jun 14 2019 at 12:26, on Zulip):

I'll just prep a follow-up PR

Last update: Nov 21 2019 at 13:05UTC